Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.21] oci: do not use conmon for exec sync #4962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jun 10, 2021
Merged

[release-1.21] oci: do not use conmon for exec sync #4962

openshift-merge-robot merged 2 commits into from
Jun 10, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 2, 2021

This is an automated cherry-pick of #4943

/assign haircommander

ExecSync requests now don't use conmon, instead calling the runtime directly, which reduces overhead.

@haircommander
oci: do not use conmon for exec sync
e7ff6ed 
It is not really needed, and causes unnecessary overhead. Plus, we drop an unkillable child from the mix
allowing cri-o to keep track of its children better.

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
oci: drop internal ExecSync structs
d11fbdc 
Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 2, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 2, 2021
Merged
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jun 2, 2021
@openshift-ci openshift-ci bot requested a review from haircommander June 2, 2021 13:48
saschagrunert
saschagrunert approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@saschagrunert
Copy link
Member

saschagrunert commented Jun 2, 2021

/test kata-containers

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Jun 2, 2021

LGTM
assuming happy tests

@haircommander
Copy link
Member

haircommander commented Jun 9, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2021
@haircommander
Copy link
Member

haircommander commented Jun 9, 2021

/retest

@openshift-bot
Copy link

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Jun 9, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@saschagrunert
Copy link
Member

saschagrunert commented Jun 10, 2021

/override ci/prow/e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2021

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 d11fbdc link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Jun 10, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7e41de0 into cri-o:release-1.21 Jun 10, 2021
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @saschagrunert @TomSweeneyRedHat @haircommander @openshift-bot @openshift-merge-robot