storage: succeed in DeleteContainer if container is unknown #4966

haircommander · 2021-06-02T18:47:20Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Signed-off-by: Peter Hunt <[email protected]>

haircommander · 2021-06-02T18:53:12Z

/cherry-pick release-1.21

this is part of the series including
#4966 and #4900

openshift-cherrypick-robot · 2021-06-02T18:53:13Z

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.21

this is part of the series including
#4966 and #4900

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2021-06-02T18:59:38Z

Codecov Report

Merging #4966 (f4aee23) into master (a54bebf) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4966      +/-   ##
==========================================
- Coverage   43.22%   43.19%   -0.03%     
==========================================
  Files         107      107              
  Lines        9860     9862       +2     
==========================================
- Hits         4262     4260       -2     
- Misses       5147     5150       +3     
- Partials      451      452       +1

TomSweeneyRedHat · 2021-06-02T19:57:36Z

LGTM
assuming happy tests.

mrunalp

/lgtm

openshift-ci · 2021-06-03T01:24:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-06-03T07:44:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T07:57:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T08:10:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T08:23:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T08:36:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T08:49:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T09:02:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T09:15:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T09:28:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T09:41:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T09:53:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T10:05:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T10:17:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T10:29:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T12:05:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T12:17:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T12:29:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T12:41:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T12:53:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T13:05:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T13:17:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-03T13:29:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

haircommander · 2021-06-03T13:32:57Z

TASK [build conmon] ************************************************************
task path: /go/src/github.com/cri-o/cri-o/contrib/test/integration/build/conmon.yml:9
fatal: [localhost]: FAILED! => {"changed": false, "cmd": "/bin/make", "msg": "In file included from src/seccomp_notify.h:4:0,\n                 from src/conmon.c:21:\nsrc/seccomp_notify_plugin.h:32:15: error: ‘struct seccomp_notif_resp’ declared inside parameter list [-Werror]\n        struct seccomp_notif_resp *sresp, int seccomp_fd, int *handled);\n               ^\nsrc/seccomp_notify_plugin.h:32:15: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]\nsrc/seccomp_notify_plugin.h:32:15: error: ‘struct seccomp_notif’ declared inside parameter list [-Werror]\nsrc/seccomp_notify_plugin.h:32:15: error: ‘struct seccomp_notif_sizes’ declared inside parameter list [-Werror]\ncc1: all warnings being treated as errors\nmake: *** [src/conmon.o] Error 1", "rc": 2, "stderr": "In file included from src/seccomp_notify.h:4:0,\n                 from src/conmon.c:21:\nsrc/seccomp_notify_plugin.h:32:15: error: ‘struct seccomp_notif_resp’ declared inside parameter list [-Werror]\n        struct seccomp_notif_resp *sresp, int seccomp_fd, int *handled);\n               ^\nsrc/seccomp_notify_plugin.h:32:15: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]\nsrc/seccomp_notify_plugin.h:32:15: error: ‘struct seccomp_notif’ declared inside parameter list [-Werror]\nsrc/seccomp_notify_plugin.h:32:15: error: ‘struct seccomp_notif_sizes’ declared inside parameter list [-Werror]\ncc1: all warnings being treated as errors\nmake: *** [src/conmon.o] Error 1\n", "stderr_lines": ["In file included from src/seccomp_notify.h:4:0,", "                 from src/conmon.c:21:", "src/seccomp_notify_plugin.h:32:15: error: ‘struct seccomp_notif_resp’ declared inside parameter list [-Werror]", "        struct seccomp_notif_resp *sresp, int seccomp_fd, int *handled);", "               ^", "src/seccomp_notify_plugin.h:32:15: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]", "src/seccomp_notify_plugin.h:32:15: error: ‘struct seccomp_notif’ declared inside parameter list [-Werror]", "src/seccomp_notify_plugin.h:32:15: error: ‘struct seccomp_notif_sizes’ declared inside parameter list [-Werror]", "cc1: all warnings being treated as errors", "make: *** [src/conmon.o] Error 1"], "stdout": "cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -DVERSION=\\\"2.0.30-dev\\\" -DGIT_COMMIT=\\\"\"75e067ed42fe44e7db00ca732c08540058e5e5fc\"\\\"   -D USE_JOURNALD=0   -D USE_SECCOMP=1  -o src/conmon.o -c src/conmon.c\n", "stdout_lines": ["cc -std=c99 -Os -Wall -Wextra -Werror -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include   -DVERSION=\\\"2.0.30-dev\\\" -DGIT_COMMIT=\\\"\"75e067ed42fe44e7db00ca732c08540058e5e5fc\"\\\"   -D USE_JOURNALD=0   -D USE_SECCOMP=1  -o src/conmon.o -c src/conmon.c"]}
	to retry, use: --limit @/go/src/github.com/cri-o/cri-o/contrib/test/integration/main.retry

it seems containers/conmon#190 broke us

openshift-bot · 2021-06-03T13:41:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

haircommander · 2021-06-03T13:46:22Z

/hold

haircommander · 2021-06-07T18:37:40Z

/hold cancel

haircommander · 2021-06-07T18:37:58Z

/retest

openshift-bot · 2021-06-07T19:45:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-07T22:47:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-07T23:12:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-08T01:47:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-08T03:23:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-08T04:59:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-08T05:35:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-06-08T06:18:35Z

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2	`f4aee23`	link	`/test e2e_cgroupv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-06-08T06:23:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-cherrypick-robot · 2021-06-08T06:53:10Z

@haircommander: new pull request created: #4977

Details

In response to this:

/cherry-pick release-1.21

this is part of the series including
#4966 and #4900

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

storage: succeed in DeleteContainer if container is unknown

f4aee23

Signed-off-by: Peter Hunt <[email protected]>

haircommander requested review from mrunalp and runcom as code owners June 2, 2021 18:47

openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 2, 2021

openshift-ci bot requested a review from sameo June 2, 2021 18:47

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021

mrunalp approved these changes Jun 3, 2021

View reviewed changes

openshift-ci bot assigned mrunalp Jun 3, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2021

openshift-merge-robot merged commit c61c168 into cri-o:master Jun 8, 2021

openshift-cherrypick-robot mentioned this pull request Jun 8, 2021

[release-1.21] storage: succeed in DeleteContainer if container is unknown #4977

Merged

This was referenced Jun 16, 2021

server: do not repeatedly error with no such id #5006

Merged

[1.20] Introduce *all of* internal wipe #5014

Merged

haircommander mentioned this pull request Jun 25, 2021

[1.19] Introduce *all of* internal wipe #5032

Closed

storage: succeed in DeleteContainer if container is unknown #4966

storage: succeed in DeleteContainer if container is unknown #4966

Uh oh!

Conversation

haircommander commented Jun 2, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

haircommander commented Jun 2, 2021

Uh oh!

openshift-cherrypick-robot commented Jun 2, 2021

Uh oh!

codecov bot commented Jun 2, 2021

Codecov Report

Uh oh!

TomSweeneyRedHat commented Jun 2, 2021

Uh oh!

mrunalp left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

haircommander commented Jun 3, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

haircommander commented Jun 3, 2021

Uh oh!

haircommander commented Jun 7, 2021

Uh oh!

haircommander commented Jun 7, 2021

Uh oh!

openshift-bot commented Jun 7, 2021