Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@haircommander
Copy link
Member

/kind bug
cherry-pick of #4907

Allow users to customize conmon's resources if a pod is in a workload.

there's a line in the kubelet leaky file that says it should be deleted
we need an importable InfraName anyway, so move all references from leaky.PodContainerName or infraName
to server/cri/types.InfraName

Signed-off-by: Peter Hunt <[email protected]>
currently, workloads are only configured for the containers in the pod.
This is insufficient for clients that want to keep a whole pod confined in a workload.

Add functionality where conmon will also be put into the workload

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 8, 2021
@haircommander
Copy link
Member Author

/retest

needs #4985 for cgroupfs test. idk why it seemed to pass on master...

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #4980 (d3a863f) into release-1.21 (478f49d) will decrease coverage by 0.22%.
The diff coverage is 12.30%.

@@               Coverage Diff                @@
##           release-1.21    #4980      +/-   ##
================================================
- Coverage         43.21%   42.98%   -0.23%     
================================================
  Files               107      107              
  Lines              9849     9905      +56     
================================================
+ Hits               4256     4258       +2     
- Misses             5142     5195      +53     
- Partials            451      452       +1     

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 d3a863f link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

/test e2e-aws

Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0be9ef8 into cri-o:release-1.21 Jun 8, 2021
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants