Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@umohnani8
Copy link
Member

@umohnani8 umohnani8 commented Jun 8, 2021

Signed-off-by: Urvashi Mohnani [email protected]

What type of PR is this?

What this PR does / why we need it:

Disable the short name mode so we don't use the alias table
when pulling images. We will revisit this is in the next release.

Which issue(s) this PR fixes:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1969599

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Disable the short name mode so we don't use the alias table
when pulling images. We will revisit this is in the next release.

Signed-off-by: Urvashi Mohnani <[email protected]>
@umohnani8 umohnani8 requested review from mrunalp and runcom as code owners June 8, 2021 16:22
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 8, 2021
@openshift-ci openshift-ci bot requested a review from kolyshkin June 8, 2021 16:22
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2021

@umohnani8: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 a239dc0 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #4984 (a239dc0) into release-1.21 (478f49d) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           release-1.21    #4984   +/-   ##
=============================================
  Coverage         43.21%   43.21%           
=============================================
  Files               107      107           
  Lines              9849     9849           
=============================================
  Hits               4256     4256           
  Misses             5142     5142           
  Partials            451      451           

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4f19d38 into cri-o:release-1.21 Jun 8, 2021
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants