-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release-1.21] Disable short name mode #4984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Disable the short name mode so we don't use the alias table when pulling images. We will revisit this is in the next release. Signed-off-by: Urvashi Mohnani <[email protected]>
mrunalp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@umohnani8: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## release-1.21 #4984 +/- ##
=============================================
Coverage 43.21% 43.21%
=============================================
Files 107 107
Lines 9849 9849
=============================================
Hits 4256 4256
Misses 5142 5142
Partials 451 451 |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: Urvashi Mohnani [email protected]
What type of PR is this?
What this PR does / why we need it:
Disable the short name mode so we don't use the alias table
when pulling images. We will revisit this is in the next release.
Which issue(s) this PR fixes:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1969599
Special notes for your reviewer:
Does this PR introduce a user-facing change?