try again on EAGAIN from dbus #4921

haircommander · 2021-05-19T15:10:54Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

when setting up conmon's cgroup

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Re-attempt setting up conmon's cgroup if it fails on EAGAIN from dbus

openshift-ci · 2021-05-19T15:15:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

utils/utils.go

Signed-off-by: Peter Hunt <[email protected]>

codecov · 2021-05-24T13:57:00Z

Codecov Report

Merging #4921 (2f6434d) into master (8c7d5f1) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #4921      +/-   ##
==========================================
- Coverage   42.92%   42.91%   -0.01%     
==========================================
  Files         107      107              
  Lines        9932     9934       +2     
==========================================
  Hits         4263     4263              
- Misses       5219     5220       +1     
- Partials      450      451       +1

haircommander · 2021-05-25T14:59:41Z

/retest

nee1esh · 2021-05-27T14:29:54Z

/test e2e-agnostic

nee1esh · 2021-05-27T14:30:16Z

/test e2e_cgroupv2

mrunalp · 2021-05-27T19:35:28Z

/lgtm

openshift-bot · 2021-05-28T05:55:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T06:19:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T06:31:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T06:43:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T08:19:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T09:19:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T09:31:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T10:07:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T10:43:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T10:55:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T11:07:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T11:19:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T11:31:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T11:43:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T12:19:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T12:31:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T12:55:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-28T13:33:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-28T14:10:41Z

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2	`2f6434d`	link	`/test e2e_cgroupv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-05-28T14:12:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

cgwalters · 2021-06-03T17:53:14Z

I looked at this a bit out of curiosity. It seems surprising that we'd see EAGAIN here, because I'd expect the Go runtime to retry in that scenario. It looks like it's happening on the initial connection.

One thing I'd recommend is somewhere early in process startup, acquire a reference to the system bus to ensure the connection is set up first. I think this is doing that implicity.

In other words call this: https://github.com/godbus/dbus/blob/e6cb346e4ee46b3c65ab915ceeb0f3739c563c9b/_examples/bluetooth_introspect.go#L11

haircommander · 2021-06-07T16:56:07Z

I believe it's up to the dbus package to handle retrying eagain, and it passes that off to the caller for some reason

/cherry-pick release-1.21

openshift-cherrypick-robot · 2021-06-07T16:56:50Z

@haircommander: #4921 failed to apply on top of branch "release-1.21":

Applying: try again on EAGAIN from dbus
Using index info to reconstruct a base tree...
M	utils/utils.go
Falling back to patching base and 3-way merge...
Auto-merging utils/utils.go
CONFLICT (content): Merge conflict in utils/utils.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 try again on EAGAIN from dbus
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

I believe it's up to the dbus package to handle retrying eagain, and it passes that off to the caller for some reason

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander requested review from mrunalp and runcom as code owners May 19, 2021 15:10

openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels May 19, 2021

openshift-ci bot requested review from saschagrunert and umohnani8 May 19, 2021 15:14

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2021

mrunalp reviewed May 21, 2021

View reviewed changes

utils/utils.go Outdated Show resolved Hide resolved

haircommander force-pushed the dbus-eagain branch 2 times, most recently from 3d5ced0 to 726f2b3 Compare May 21, 2021 13:45

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2021

try again on EAGAIN from dbus

2f6434d

Signed-off-by: Peter Hunt <[email protected]>

haircommander force-pushed the dbus-eagain branch from 726f2b3 to 2f6434d Compare May 24, 2021 13:44

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2021

openshift-ci bot assigned mrunalp May 27, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2021

openshift-merge-robot merged commit 64d6ff4 into cri-o:master May 28, 2021

kolyshkin mentioned this pull request Jul 12, 2021

[1.20] cgmgr: reuse dbus connection #5058

Merged

try again on EAGAIN from dbus #4921

try again on EAGAIN from dbus #4921

Uh oh!

Conversation

haircommander commented May 19, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci bot commented May 19, 2021

Uh oh!

Uh oh!

codecov bot commented May 24, 2021

Codecov Report

Uh oh!

haircommander commented May 25, 2021

Uh oh!

nee1esh commented May 27, 2021

Uh oh!

nee1esh commented May 27, 2021

Uh oh!

mrunalp commented May 27, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

openshift-ci bot commented May 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented May 28, 2021

Uh oh!

cgwalters commented Jun 3, 2021

Uh oh!

haircommander commented Jun 7, 2021

Uh oh!

openshift-cherrypick-robot commented Jun 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci bot commented May 28, 2021 •

edited

Loading