[1.21] bump c/storage to 1.31.1 #4932
Conversation
|
fixes #4777 |
| if iNdEx < 0 { | ||
| return 0, ErrInvalidLengthMetrics | ||
| } | ||
| if depth == 0 { |
There was a problem hiding this comment.
opt.semgrep.eqeq-is-bad: useless comparison operation depth == depth or depth != depth
(at-me in a reply with help or ignore)
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
opt.semgrep.go.lang.correctness.useless-eqeq.hardcoded-eq-true-or-false: Useless if statement, always the same behavior
(at-me in a reply with help or ignore)
| // to ProgramInfo.Tag to figure out whether a loaded program matches | ||
| // certain instructions. | ||
| func (insns Instructions) Tag(bo binary.ByteOrder) (string, error) { | ||
| h := sha1.New() |
There was a problem hiding this comment.
opt.semgrep.go.lang.security.audit.crypto.bad_imports.insecure-module-used: Insecure module used.
(at-me in a reply with help or ignore)
| // to ProgramInfo.Tag to figure out whether a loaded program matches | ||
| // certain instructions. | ||
| func (insns Instructions) Tag(bo binary.ByteOrder) (string, error) { | ||
| h := sha1.New() |
There was a problem hiding this comment.
opt.semgrep.go.lang.security.audit.crypto.use_of_weak_crypto.use-of-sha1: Detected SHA1 hash algorithm which is considered insecure. SHA1 is not
collision resistant and is therefore not suitable as a cryptographic
signature. Use SHA256 or SHA3 instead.
(at-me in a reply with help or ignore)
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
opt.semgrep.hardcoded-eq-true-or-false: useless if statement, always the same behavior
(at-me in a reply with help or ignore)
|
Need rebase |
370371d to
b631ac4
Compare
|
rebased! |
Signed-off-by: Peter Hunt <[email protected]>
b631ac4 to
a12ce4e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: Peter Hunt [email protected]
What type of PR is this?
/kind dependency-change
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?