Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.21] Add support to drop ALL and add back few capabilities #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 21, 2021
Merged

[release-1.21] Add support to drop ALL and add back few capabilities #4935

openshift-merge-robot merged 1 commit into from
May 21, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 21, 2021

This is an automated cherry-pick of #4923

/assign haircommander

Fix drop ALL and add back few caps behavior to not include the default configured capabilities

@mrunalp
Add support to drop ALL and add back few capabilities
2f4af82 
The current implemention has an issue where we add the default
capabilties when the user does drop ALL and add few.

Signed-off-by: Mrunal Patel <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 21, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 21, 2021
Merged
@openshift-ci openshift-ci bot requested review from nalind and vrothberg May 21, 2021 02:55
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 2f4af82 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@haircommander
Copy link
Member

haircommander commented May 21, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1baccda into cri-o:release-1.21 May 21, 2021
@openshift-ci openshift-ci bot mentioned this pull request Jun 8, 2021
Closed
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@nalind nalind Awaiting requested review from nalind

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @haircommander @saschagrunert @openshift-merge-robot @mrunalp