Thanks to visit codestin.com
Credit goes to github.com

Skip to content

criocli: add privileged_without_host_devices flag to runtime handler config #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 3, 2021
Merged

criocli: add privileged_without_host_devices flag to runtime handler config #5054

openshift-merge-robot merged 1 commit into from
Jul 3, 2021

Conversation

@littlejawa
Copy link
Contributor

@littlejawa littlejawa commented Jul 1, 2021 •
edited
Loading

Make it possible to configure the privileged_without_host_devices flag
when generating the configuration file for a different runtime handler.

Using this in integration tests (helpers.bash) to allow custom configurations.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Add a parameter to the "runtimes" fields, so that we can customize the flag "privileged_without_host_devices" for a given runtime.
Without this, the flag will always be 'false' in the generated configuration.

Does this PR introduce a user-facing change?

The privileged_without_host_devices flag can now be given a an additional parameter to configure a runtime

@littlejawa littlejawa requested review from mrunalp and runcom as code owners July 1, 2021 12:16
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Jul 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2021

Hi @littlejawa. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 1, 2021
@openshift-ci openshift-ci bot requested review from sameo and vrothberg July 1, 2021 12:16
@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 1, 2021

/cc @fidencio - can you get a look ?

@codecov
Copy link

codecov bot commented Jul 1, 2021 •
edited
Loading

Codecov Report

Merging #5054 (147c58a) into master (0aa5724) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 147c58a differs from pull request most recent head 6507411. Consider uploading reports for the commit 6507411 to get more accurate results

@@            Coverage Diff             @@
##           master    #5054      +/-   ##
==========================================
- Coverage   41.70%   41.69%   -0.01%     
==========================================
  Files         108      108              
  Lines       10163    10169       +6     
==========================================
+ Hits         4238     4240       +2     
- Misses       5476     5480       +4     
  Partials      449      449

@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 1, 2021

/hold
Need to edit documentation / usage

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2021
@littlejawa littlejawa force-pushed the runtime_handler_add_privileged_flag branch from 7d07e61 to 1e6ecfd Compare July 2, 2021 07:15
@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 2, 2021

/unhold

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 2, 2021
@littlejawa
Copy link
Contributor Author

littlejawa commented Jul 2, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@littlejawa: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fidencio
Copy link
Contributor

fidencio commented Jul 2, 2021

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2021
@fidencio
Copy link
Contributor

fidencio commented Jul 2, 2021

LGTM assuming happy tests.
@haircommander, @saschagrunert, @fgiudici, in case you want to take a look at this one as well.

@littlejawa littlejawa force-pushed the runtime_handler_add_privileged_flag branch from 1e6ecfd to 7442bf9 Compare July 2, 2021 07:58
fidencio
fidencio reviewed Jul 2, 2021
View reviewed changes
@fidencio
Copy link
Contributor

fidencio commented Jul 2, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2021
@littlejawa littlejawa force-pushed the runtime_handler_add_privileged_flag branch from 7442bf9 to 6507411 Compare July 2, 2021 08:29
@littlejawa
criocli: add privileged_without_host_devices flag to runtime handler …
6507411 
…config

Make it possible to configure the privileged_without_host_devices flag
when generating the configuration file for a different runtime handler.

Using this in integration tests (helpers.bash) to allow custom configurations.

Signed-off-by: Julien Ropé <[email protected]>
@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

17 similar comments
@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2021 •
edited
Loading

@littlejawa: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 6507411 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d41627b into cri-o:master Jul 3, 2021
@littlejawa littlejawa deleted the runtime_handler_add_privileged_flag branch October 25, 2021 14:10
littlejawa added a commit to littlejawa/tests that referenced this pull request Nov 2, 2021
@littlejawa
ci: enable tests requiring PRIVILEGED_WITHOUT_HOST_DEVICES
7b52f24 
The PRIVILEGED_WITHOUT_HOST_DEVICES flag was not available in cri-o
before v1.22. But this flag is necessary for two of our tests.

This commit is setting this flag and enabling those tests for v1.22
and above.

(see: cri-o/cri-o#5054)

Fixes: kata-containers#4139

Signed-off-by: Julien Ropé <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fidencio fidencio fidencio left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@sameo sameo Awaiting requested review from sameo

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@littlejawa @fidencio @haircommander @openshift-bot @openshift-merge-robot