Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Vendor c/storage test branch and add integration tests #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saschagrunert wants to merge 1 commit into from
Closed

Vendor c/storage test branch and add integration tests #5005

saschagrunert wants to merge 1 commit into from

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 16, 2021 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This change should verify that we can fix the layers.json corruption from c/storage.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Refers to containers/storage#943

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from fidencio and kolyshkin June 16, 2021 13:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@saschagrunert saschagrunert mentioned this pull request Jun 16, 2021
Merged
@codecov
Copy link

codecov bot commented Jun 16, 2021 •
edited
Loading

Codecov Report

Merging #5005 (a45d83b) into master (ac9b621) will not change coverage.
The diff coverage is n/a.

❗ Current head a45d83b differs from pull request most recent head e1d2a3c. Consider uploading reports for the commit e1d2a3c to get more accurate results

@@           Coverage Diff           @@
##           master    #5005   +/-   ##
=======================================
  Coverage   42.38%   42.38%           
=======================================
  Files         108      108           
  Lines       10008    10008           
=======================================
  Hits         4242     4242           
  Misses       5312     5312           
  Partials      454      454

@saschagrunert saschagrunert force-pushed the corrupted-image branch 2 times, most recently from 7a01c57 to 72d4818 Compare June 16, 2021 14:53
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 16, 2021

/test integration_fedora

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 16, 2021

/test integration_rhel

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 16, 2021

/hold

let's not merge the vendored dependency change :)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@fidencio
Copy link
Contributor

fidencio commented Jun 16, 2021

/test kata-containers

@fidencio
Copy link
Contributor

fidencio commented Jun 16, 2021

@saschagrunert, please, Tomorrow remind me to test this with kata-container locally. I need to understand whether the CI is flaky or if this is actually something we should worry about.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 17, 2021

@fidencio I should remind you to test that PR with kata-containers locally. 🙃

@fidencio
Copy link
Contributor

fidencio commented Jun 17, 2021

@saschagrunert, as far as I could see CI was flaky and it was not related to this PR.
Please, rebase it and let's rerun the tests (which are now green), if we hit a failure again I will do a deep dive on that.

Thanks for the reminder! :-)

@saschagrunert
Vendor c/storage test branch and add integration tests
e1d2a3c 
This change should verify that we can fix the layers.json corruption
from c/storage.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@saschagrunert: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_fedora e1d2a3c link /test integration_fedora
ci/openshift-jenkins/integration_rhel e1d2a3c link /test integration_rhel
ci/prow/e2e-agnostic e1d2a3c link /test e2e-agnostic
ci/openshift-jenkins/e2e_crun e1d2a3c link /test e2e_crun
ci/openshift-jenkins/e2e_crun_cgroupv2 e1d2a3c link /test e2e_cgroupv2
ci/openshift-jenkins/e2e_rhel e1d2a3c link /test e2e_rhel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fidencio
Copy link
Contributor

fidencio commented Jun 17, 2021

LGTM, thanks @saschagrunert!

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 18, 2021

The bump to c/storage v1.32.3 will fix this automatically via dependabot.

@saschagrunert saschagrunert mentioned this pull request Jun 18, 2021
Merged
@saschagrunert saschagrunert deleted the corrupted-image branch June 23, 2022 11:06
saschagrunert added a commit to saschagrunert/cri-o that referenced this pull request Sep 6, 2022
@saschagrunert
Readd layer image corruption test
ddaa90f 
The test was originally introduced by testing via the PR:
cri-o#5005

To avoid future regressions we now readd the test.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert mentioned this pull request Sep 6, 2022
Closed
saschagrunert added a commit to saschagrunert/cri-o that referenced this pull request Sep 6, 2022
@saschagrunert
Readd layer image corruption test
81ad94f 
The test was originally introduced by testing via the PR:
cri-o#5005

To avoid future regressions we now readd the test.

Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert added a commit to saschagrunert/cri-o that referenced this pull request Sep 9, 2022
@saschagrunert
Readd layer image corruption test
b1d17d0 
The test was originally introduced by testing via the PR:
cri-o#5005

To avoid future regressions we now readd the test.

Signed-off-by: Sascha Grunert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@fidencio fidencio Awaiting requested review from fidencio

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saschagrunert @fidencio