server: do not repeatedly error with no such id #5006

haircommander · 2021-06-16T19:42:51Z

as it should not be a fatal error, as it indicates we've already cleaned up

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

haircommander · 2021-06-16T19:43:01Z

similar to #4966

codecov · 2021-06-16T19:50:35Z

Codecov Report

Merging #5006 (3b9385b) into master (cd7f051) will increase coverage by 0.66%.
The diff coverage is 0.00%.

❗ Current head 3b9385b differs from pull request most recent head e648fde. Consider uploading reports for the commit e648fde to get more accurate results

@@            Coverage Diff             @@
##           master    #5006      +/-   ##
==========================================
+ Coverage   41.72%   42.38%   +0.66%     
==========================================
  Files         108      108              
  Lines       10158    10012     -146     
==========================================
+ Hits         4238     4244       +6     
+ Misses       5471     5314     -157     
- Partials      449      454       +5

server/container_create.go

saschagrunert

/retest

haircommander · 2021-06-17T17:54:19Z

/retest

TomSweeneyRedHat

LGTM
assuming you never want to see this error. Based on the PR title, I thought you'd want to see the first instance, but not repeated ones.

mrunalp · 2021-06-25T04:25:33Z

server/container_create.go

 )

+// sync with https://github.com/containers/storage/blob/7fe03f6c765f2adbc75a5691a1fb4f19e56e7071/pkg/truncindex/truncindex.go#L92
+const noSuchID = "no such id"


Why can't we have the storage code return this typed error instead - https://github.com/containers/storage/blob/7fe03f6c765f2adbc75a5691a1fb4f19e56e7071/pkg/truncindex/truncindex.go#L23?

easier to backport this :) I planned on updating the error in main

haircommander · 2021-06-29T13:47:13Z

/retest

as it should not be a fatal error, as it indicates we've already cleaned up Signed-off-by: Peter Hunt <[email protected]>

haircommander · 2021-06-29T14:48:08Z

/retest

haircommander · 2021-06-29T14:48:22Z

/retest

haircommander · 2021-07-02T18:34:58Z

/retest

haircommander · 2021-07-08T13:51:08Z

@saschagrunert PTAL
/override ci/prow/e2e-gcp

openshift-ci · 2021-07-08T13:51:12Z

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-gcp

Details

In response to this:

@saschagrunert PTAL
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saschagrunert

/lgtm

openshift-ci · 2021-07-15T13:30:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander · 2021-07-15T13:43:14Z

/cherry-pick release-1.21

openshift-cherrypick-robot · 2021-07-15T13:43:15Z

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-15T14:19:50Z

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2	`e648fde`	link	`/test e2e_cgroupv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

haircommander · 2021-07-15T14:21:36Z

/retest-required

openshift-cherrypick-robot · 2021-07-15T15:10:58Z

@haircommander: #5006 failed to apply on top of branch "release-1.21":

Applying: server: don't repeatedly error with no such id
Using index info to reconstruct a base tree...
M	server/container_create.go
M	server/sandbox_run_linux.go
Falling back to patching base and 3-way merge...
Auto-merging server/sandbox_run_linux.go
CONFLICT (content): Merge conflict in server/sandbox_run_linux.go
Auto-merging server/container_create.go
CONFLICT (content): Merge conflict in server/container_create.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 server: don't repeatedly error with no such id
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander requested review from mrunalp and runcom as code owners June 16, 2021 19:42

openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 16, 2021

openshift-ci bot requested review from sboeuf and vrothberg June 16, 2021 19:42

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021

saschagrunert reviewed Jun 17, 2021

View reviewed changes

server/container_create.go Outdated Show resolved Hide resolved

saschagrunert approved these changes Jun 17, 2021

View reviewed changes

haircommander force-pushed the no-no-such-id branch from 6b4aab0 to 6e06a32 Compare June 17, 2021 14:10

TomSweeneyRedHat reviewed Jun 17, 2021

View reviewed changes

haircommander mentioned this pull request Jun 17, 2021

[1.20] Introduce *all of* internal wipe #5014

Merged

mrunalp reviewed Jun 25, 2021

View reviewed changes

haircommander mentioned this pull request Jun 25, 2021

[1.19] Introduce *all of* internal wipe #5032

Closed

server: don't repeatedly error with no such id

e648fde

as it should not be a fatal error, as it indicates we've already cleaned up Signed-off-by: Peter Hunt <[email protected]>

haircommander force-pushed the no-no-such-id branch from 6e06a32 to e648fde Compare June 29, 2021 14:40

haircommander changed the title ~~server: don't repeatedly error with no such id~~ server: do not repeatedly error with no such id Jun 29, 2021

saschagrunert approved these changes Jul 15, 2021

View reviewed changes

openshift-ci bot assigned saschagrunert Jul 15, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2021

openshift-merge-robot merged commit de5e0fe into cri-o:master Jul 15, 2021

haircommander mentioned this pull request Jul 29, 2021

[1.21] server: do not repeatedly error with no such id #5138

Merged

server: do not repeatedly error with no such id #5006

server: do not repeatedly error with no such id #5006

Conversation

haircommander commented Jun 16, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

haircommander commented Jun 16, 2021

Uh oh!

codecov bot commented Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

haircommander commented Jun 17, 2021

Uh oh!

TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

Uh oh!

mrunalp Jun 25, 2021

Choose a reason for hiding this comment

Uh oh!

haircommander Jun 25, 2021

Choose a reason for hiding this comment

Uh oh!

haircommander commented Jun 29, 2021

Uh oh!

haircommander commented Jun 29, 2021

Uh oh!

haircommander commented Jun 29, 2021

Uh oh!

haircommander commented Jul 2, 2021

Uh oh!

haircommander commented Jul 8, 2021

Uh oh!

openshift-ci bot commented Jul 8, 2021

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jul 15, 2021

Uh oh!

haircommander commented Jul 15, 2021

Uh oh!

openshift-cherrypick-robot commented Jul 15, 2021

Uh oh!

openshift-ci bot commented Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haircommander commented Jul 15, 2021

Uh oh!

openshift-cherrypick-robot commented Jul 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Jun 16, 2021 •

edited

Loading

openshift-ci bot commented Jul 15, 2021 •

edited

Loading