Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix linkmode retrieval for non en_US systems #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Aug 5, 2021
Merged

Fix linkmode retrieval for non en_US systems #5168

openshift-ci merged 1 commit into from
Aug 5, 2021

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 5, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

We now set the environment to LANG=C before running ldd. This way we
can ensure that the error checks are consistent.

Which issue(s) this PR fixes:

Fixes #5165

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed linkmode detection for on `en_US` systems `crio version`

@saschagrunert
Fix linkmode retrieval for non en_US systems
8d11fc6 
We now set the environment to `LANG=C` before running `ldd`. This way we
can ensure that the error checks are consistent.

Fixes cri-o#5165

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #5168 (8d11fc6) into master (226e658) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5168      +/-   ##
==========================================
- Coverage   44.03%   44.00%   -0.04%     
==========================================
  Files         111      111              
  Lines       11497    11506       +9     
==========================================
  Hits         5063     5063              
- Misses       5952     5961       +9     
  Partials      482      482

@saschagrunert
Copy link
Member Author

saschagrunert commented Aug 5, 2021

/test integration_rhel

@saschagrunert
Copy link
Member Author

saschagrunert commented Aug 5, 2021

/test integration_fedora

@haircommander
Copy link
Member

haircommander commented Aug 5, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@haircommander haircommander added this to the 1.22 milestone Aug 5, 2021
@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021 •
edited
Loading

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 8d11fc6 link /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 8d11fc6 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@fgiudici
Copy link
Contributor

fgiudici commented Aug 5, 2021

lgtm

@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 5, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 2c92506 into cri-o:master Aug 5, 2021
@saschagrunert saschagrunert deleted the linkmode-fix branch August 6, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@haircommander haircommander Awaiting requested review from haircommander

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

1.22

Development

Successfully merging this pull request may close these issues.

CRI-O fails to detect link mode of binary on non english language OS

4 participants

@saschagrunert @haircommander @openshift-bot @fgiudici