gh actions: drop 1.14 as legacy go version #5176
Conversation
Signed-off-by: Peter Hunt <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5176 +/- ##
==========================================
- Coverage 44.02% 44.00% -0.02%
==========================================
Files 111 111
Lines 11506 11506
==========================================
- Hits 5065 5063 -2
- Misses 5959 5961 +2
Partials 482 482 |
|
LGTM |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| env: | ||
| GO_VERSION: '1.16' | ||
| GO_VERSION_LEGACY: '1.14' | ||
| GO_VERSION_LEGACY: '1.15' |
There was a problem hiding this comment.
This is already part of #5109. It also looks like that we cannot build with go 1.15 either.
|
closing as this is part of #5109 |
Signed-off-by: Peter Hunt [email protected]
What type of PR is this?
/kind ci
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?