Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: fix another repeated no such id error #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
haircommander wants to merge 1 commit into from
Closed

server: fix another repeated no such id error #5137

haircommander wants to merge 1 commit into from
+5 −2

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Jul 29, 2021

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@haircommander haircommander mentioned this pull request Jul 29, 2021
Merged
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Jul 29, 2021
@openshift-ci openshift-ci bot requested a review from vrothberg July 29, 2021 20:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021 •
edited
Loading

Codecov Report

Merging #5137 (9ab2ea7) into main (b6d6cde) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5137      +/-   ##
==========================================
- Coverage   43.91%   43.91%   -0.01%     
==========================================
  Files         110      110              
  Lines       11453    11455       +2     
==========================================
  Hits         5030     5030              
- Misses       5946     5948       +2     
  Partials      477      477

saschagrunert
saschagrunert approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member Author

haircommander commented Jul 30, 2021

/test integration_crun

@haircommander haircommander mentioned this pull request Jul 30, 2021
Closed
@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Jul 30, 2021

LGTM
assuming happy tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 9ab2ea7 link /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 9ab2ea7 link /test integration_cgroupv2
ci/prow/e2e-agnostic 9ab2ea7 link /test e2e-agnostic

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2022

@haircommander: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

haircommander commented Feb 28, 2022

LOL I need to be better about making sure my PRs merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haircommander @TomSweeneyRedHat @saschagrunert