Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: notify user when network is not ready yet #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Dec 15, 2021
Merged

server: notify user when network is not ready yet #5284

openshift-merge-robot merged 2 commits into from
Dec 15, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Sep 8, 2021 •
edited
Loading

Or else they don't know why cri-o is waiting

also, catch server shutdown so the process does eventually shutdown.

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix a bug where CRI-O would never shutdown if the networking plugin wasn't configured correctly

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Sep 8, 2021
@openshift-ci openshift-ci bot requested a review from sameo September 8, 2021 18:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@haircommander
Copy link
Member Author

haircommander commented Sep 8, 2021

/cherry-pick release-1.22

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 8, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

Merging #5284 (89889b7) into main (fc844e4) will increase coverage by 0.47%.
The diff coverage is 12.50%.

❗ Current head 89889b7 differs from pull request most recent head 87aede8. Consider uploading reports for the commit 87aede8 to get more accurate results

@@            Coverage Diff             @@
##             main    #5284      +/-   ##
==========================================
+ Coverage   43.27%   43.75%   +0.47%     
==========================================
  Files         120      118       -2     
  Lines       11995    11727     -268     
==========================================
- Hits         5191     5131      -60     
+ Misses       6309     6109     -200     
+ Partials      495      487       -8

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 8, 2021
@haircommander
Copy link
Member Author

haircommander commented Sep 9, 2021

/retest

@haircommander haircommander changed the title server: notify user when network isn't ready yet server: notify user when network is not ready yet Sep 9, 2021
@haircommander
Copy link
Member Author

haircommander commented Sep 9, 2021

/retest

@fgiudici
Copy link
Contributor

fgiudici commented Sep 10, 2021

lgtm
Nice patch!

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Sep 10, 2021

LGTM
once tests are happy

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021
@haircommander haircommander added this to the 1.23 milestone Nov 30, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2021
@haircommander
server: notify user when network isn't ready yet
f3d2c60 
or else they just wait forever

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
cni manager: catch server shutdown
87aede8 
or else CRI-O will never stop if the network isn't up

Signed-off-by: Peter Hunt <[email protected]>
mrunalp
mrunalp approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member Author

haircommander commented Dec 13, 2021

/override ci/openshift-jenkins/integration_crun

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

23 similar comments
@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 15, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021 •
edited
Loading

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 87aede8 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 87aede8 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

haircommander commented Dec 15, 2021

/override ci/openshift-jenkins/integration_crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun

Details

In response to this:

/override ci/openshift-jenkins/integration_crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8da1f67 into cri-o:main Dec 15, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 15, 2021

@haircommander: new pull request created: #5507

Details

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom

@sameo sameo Awaiting requested review from sameo

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

8 participants

@haircommander @openshift-cherrypick-robot @fgiudici @TomSweeneyRedHat @openshift-bot @saschagrunert @mrunalp @openshift-merge-robot