Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Switch to build tag for linkmode #5239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 23, 2021
Merged

Switch to build tag for linkmode #5239

openshift-merge-robot merged 1 commit into from
Aug 23, 2021

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 23, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We now do not call ldd any more when finding out the linkmode of the
binary, instead we rely on build tags.

Which issue(s) this PR fixes:

Closes #5165

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Use build tag for `linkmode` detection on `crio version`.

@saschagrunert
Switch to build tag for linkmode
15f3584 
We now do not call `ldd` any more when finding out the linkmode of the
binary, instead we rely on build tags.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 23, 2021
@openshift-ci openshift-ci bot requested review from fidencio and rhatdan August 23, 2021 08:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2021
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #5239 (77164de) into master (177ed5f) will increase coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head 77164de differs from pull request most recent head 15f3584. Consider uploading reports for the commit 15f3584 to get more accurate results

@@            Coverage Diff             @@
##           master    #5239      +/-   ##
==========================================
+ Coverage   44.13%   44.20%   +0.07%     
==========================================
  Files         117      117              
  Lines       11650    11627      -23     
==========================================
- Hits         5142     5140       -2     
+ Misses       6022     6001      -21     
  Partials      486      486

@saschagrunert saschagrunert mentioned this pull request Aug 23, 2021
Closed
@haircommander
Copy link
Member

haircommander commented Aug 23, 2021

/lgtm

good idea

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@openshift-bot
Copy link

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@saschagrunert
Copy link
Member Author

saschagrunert commented Aug 23, 2021

/retest

@openshift-bot
Copy link

openshift-bot commented Aug 23, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@saschagrunert
Copy link
Member Author

saschagrunert commented Aug 23, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 4e5a828 into cri-o:master Aug 23, 2021
@saschagrunert saschagrunert deleted the linkmode-tag branch August 24, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@fidencio fidencio Awaiting requested review from fidencio

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CRI-O fails to detect link mode of binary on non english language OS

4 participants

@saschagrunert @haircommander @openshift-bot @openshift-merge-robot