add allowed annotations to workloads #5358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab09369 to
9cb2570
Compare
Codecov Report
@@ Coverage Diff @@
## main #5358 +/- ##
==========================================
- Coverage 43.72% 43.61% -0.12%
==========================================
Files 118 118
Lines 11752 11814 +62
==========================================
+ Hits 5139 5153 +14
- Misses 6125 6169 +44
- Partials 488 492 +4 |
6f0acaa to
6f5215c
Compare
6f5215c to
6b5fef3
Compare
Member
Author
|
thanks @TomSweeneyRedHat adapted (mostly) as suggested |
6b5fef3 to
cb2e064
Compare
Member
Author
|
/retest |
cb2e064 to
94e3de4
Compare
Member
Author
|
rebased on #5373 |
94e3de4 to
8344280
Compare
ff7c2da to
1ba6970
Compare
Member
Author
|
@cri-o/cri-o-maintainers PTAL |
saschagrunert
approved these changes
Oct 5, 2021
docs/crio.conf.5.md
Outdated
| "io.containers.trace-syscall" for tracing syscalls via the OCI seccomp BPF hook. | ||
|
|
||
| ### CRIO.RUNTIME.WORKLOADS TABLE | ||
| The "crio.runtime.workloads" table defines a list of workloads--a way to customize the behavior of a pod and container. |
Member
There was a problem hiding this comment.
nit:
Suggested change
| The "crio.runtime.workloads" table defines a list of workloads--a way to customize the behavior of a pod and container. | |
| The "crio.runtime.workloads" table defines a list of workloads - a way to customize the behavior of a pod and container. |
1ba6970 to
6b5ee39
Compare
Signed-off-by: Peter Hunt <[email protected]>
6b5ee39 to
0b3ca53
Compare
as well as mark runtime class version of allowed_annotations as deprecated Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
0b3ca53 to
01ee373
Compare
Member
Author
|
updated and fixed tests |
Member
Author
|
/retest |
Contributor
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ajwock
pushed a commit
to ajwock/cri-o
that referenced
this pull request
Oct 18, 2021
add allowed annotations to workloads
This was referenced Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Hunt [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds allowed_annotations to workloads, and deprecates the one in runtime classes.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?