Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.22] server: fix some hostNet handling in container creation #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Sep 29, 2021
Merged

[release-1.22] server: fix some hostNet handling in container creation #5365

openshift-merge-robot merged 3 commits into from
Sep 29, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 29, 2021

This is an automated cherry-pick of #5244

/assign haircommander

Fix a bug where host network containers couldn't read their cgroup hierarchy

@haircommander
server: don't recalculate hostnet
5375572 
Signed-off-by: Peter Hunt <[email protected]>
@haircommander
server: use container level host network setting
b40d922 
to remain consistent with other times it's specified

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
server: mount cgroup if hostNetwork
54f3437 
Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 29, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 29, 2021
Merged
@openshift-ci openshift-ci bot requested review from rhatdan and vrothberg September 29, 2021 17:04
@haircommander
Copy link
Member

haircommander commented Sep 29, 2021

/lgtm
/approve
/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Sep 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021
@haircommander haircommander mentioned this pull request Sep 29, 2021
Closed
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #5365 (54f3437) into release-1.22 (feb4cbe) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.22    #5365      +/-   ##
================================================
- Coverage         43.75%   43.73%   -0.02%     
================================================
  Files               118      118              
  Lines             11731    11731              
================================================
- Hits               5133     5131       -2     
- Misses             6110     6112       +2     
  Partials            488      488

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2021 •
edited
Loading

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 54f3437 link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Sep 29, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Sep 29, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 29, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bdf286c into cri-o:release-1.22 Sep 29, 2021
@haircommander
Copy link
Member

haircommander commented Oct 8, 2021

/cherry-pick release-1.21

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 8, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Oct 8, 2021

@haircommander: new pull request created: #5389

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @haircommander @openshift-bot @openshift-merge-robot