Remove usge of deprecated apt-key in Ubuntu install #5369

tadayosi · 2021-10-01T02:37:09Z

What type of PR is this?

/kind documentation

What this PR does / why we need it:

apt-key is deprecated and will be removed after Ubuntu 22.04. Follow this guide and use gpg instead.
https://wiki.debian.org/DebianRepository/UseThirdParty

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Signed-off-by: Tadayoshi Sato <[email protected]>

openshift-ci · 2021-10-01T02:37:17Z

Hi @tadayosi. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TomSweeneyRedHat · 2021-10-01T16:09:08Z

install.md

 ```shell
-echo "deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/$OS/ /" > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list
-echo "deb https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable:/cri-o:/$VERSION/$OS/ /" > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable:cri-o:$VERSION.list
+echo "deb [signed-by=/usr/share/keyrings/libcontainers-archive-keyring.gpg] https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/$OS/ /" > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list


Is this correct? Usually, you see parens after brackets so that it creates a link. I'm not an Unbuntu install guru, so maybe this is right? It looks like:

echo "deb [signed-by=/usr/share/keyrings/libcontainers-archive-keyring.gpg] https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/$OS/ /" > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list

yeah this is correct, it's writing that string to the source.list file which is needed to add the correct key

haircommander · 2021-10-01T17:33:16Z

/ok-to-test
/approve

LGTM (tested and it works)

@cri-o/cri-o-maintainers PTAL

openshift-ci · 2021-10-01T17:33:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, tadayosi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander · 2021-10-01T17:33:28Z

thanks @tadayosi !

codecov · 2021-10-01T17:45:09Z

Codecov Report

Merging #5369 (086386b) into main (884e5f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5369   +/-   ##
=======================================
  Coverage   43.75%   43.75%           
=======================================
  Files         118      118           
  Lines       11737    11737           
=======================================
  Hits         5135     5135           
  Misses       6114     6114           
  Partials      488      488

QiWang19 · 2021-10-02T18:50:12Z

/lgtm

openshift-bot · 2021-10-02T19:05:16Z

/retest-required