Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix runtime handler docs #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 11, 2021
Merged

Fix runtime handler docs #5395

openshift-merge-robot merged 1 commit into from
Oct 11, 2021

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Oct 11, 2021

What type of PR is this?

/kind documentation

What this PR does / why we need it:

We now use "runtime handler" instead of "runtime_handler", which was
only referencing an internal variable not visible to the user.

Which issue(s) this PR fixes:

Fixes #5393

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Improve runtime handler documentation to mention "runtime handler" in favor of the internal "runtime_handler" variable.

@saschagrunert
Fix runtime handler docs
cd7f7cb 
We now use "runtime handler" instead of "runtime_handler", which was
only referencing an internal variable not visible to the user.

Fixes cri-o#5393

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 11, 2021
@openshift-ci openshift-ci bot requested a review from umohnani8 October 11, 2021 07:59
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #5395 (4cb8eba) into main (c8bbae9) will not change coverage.
The diff coverage is n/a.

❗ Current head 4cb8eba differs from pull request most recent head cd7f7cb. Consider uploading reports for the commit cd7f7cb to get more accurate results

@@           Coverage Diff           @@
##             main    #5395   +/-   ##
=======================================
  Coverage   43.72%   43.72%           
=======================================
  Files         118      118           
  Lines       11749    11749           
=======================================
  Hits         5137     5137           
  Misses       6124     6124           
  Partials      488      488

@fidencio
Copy link
Contributor

fidencio commented Oct 11, 2021

LGTM, thanks @saschagrunert!

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Oct 11, 2021

LGTM

@haircommander
Copy link
Member

haircommander commented Oct 11, 2021

/lgtm
/retest
/override ci/openshift-jenkins/integration_rhel

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_rhel

Details

In response to this:

/lgtm
/retest
/override ci/openshift-jenkins/integration_rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021 •
edited
Loading

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 cd7f7cb link false /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 cd7f7cb link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Oct 11, 2021

/override ci/openshift-jenkins/integration_rhel

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_rhel

Details

In response to this:

/override ci/openshift-jenkins/integration_rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

openshift-bot commented Oct 11, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member

haircommander commented Oct 11, 2021

/override ci/openshift-jenkins/e2e_rhel

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/e2e_rhel

Details

In response to this:

/override ci/openshift-jenkins/e2e_rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ec27c38 into cri-o:main Oct 11, 2021
@saschagrunert saschagrunert deleted the runtime-handler-docs branch October 12, 2021 07:22
@openshift-ci openshift-ci bot mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crio.conf.5: runtime_handler → runtime handler

6 participants

@saschagrunert @fidencio @TomSweeneyRedHat @haircommander @openshift-bot @openshift-merge-robot