Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: do not wait forever on conmon cgroup move fail #5306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 14, 2021
Merged

server: do not wait forever on conmon cgroup move fail #5306

openshift-merge-robot merged 1 commit into from
Sep 14, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Sep 13, 2021

If we haven't signaled on the stop pipe, then conmon will be sitting waiting to be told to start
Instead, we need to kill the process.

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix a bug where CRI-O waits forever on a conmon process that will not stop

@haircommander
server: don't wait forever on conmon cgroup move fail
3fd1cd2 
If we haven't signaled on the stop pipe, then conmon will be sitting waiting to be told to start
Instead, we need to kill the process.

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 13, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #5306 (1abf0d9) into master (e9592e2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 1abf0d9 differs from pull request most recent head 3fd1cd2. Consider uploading reports for the commit 3fd1cd2 to get more accurate results

@@            Coverage Diff             @@
##           master    #5306      +/-   ##
==========================================
- Coverage   43.74%   43.72%   -0.02%     
==========================================
  Files         118      118              
  Lines       11722    11722              
==========================================
- Hits         5128     5126       -2     
- Misses       6107     6109       +2     
  Partials      487      487

@haircommander haircommander changed the title server: don't wait forever on conmon cgroup move fail server: do not wait forever on conmon cgroup move fail Sep 13, 2021
@haircommander
Copy link
Member Author

haircommander commented Sep 13, 2021

/retest

@haircommander
Copy link
Member Author

haircommander commented Sep 13, 2021

/retest
/cherry-pick release-1.22

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 13, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.22 in a new PR and assign it to you.

Details

In response to this:

/retest
/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

giuseppe
giuseppe approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgiudici
Copy link
Contributor

fgiudici commented Sep 14, 2021

lgtm

mrunalp
mrunalp approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgiudici, giuseppe, haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2021

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/kata-jenkins 3fd1cd2 link true /test kata-containers
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 3fd1cd2 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 3fd1cd2 link false /test e2e_cgroupv2
ci/kata-jenkins 3fd1cd2 link true /test kata-containers

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3e1f10b into cri-o:main Sep 14, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 14, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 14, 2021

@haircommander: new pull request created: #5309

Details

In response to this:

/retest
/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander haircommander mentioned this pull request Sep 20, 2021
Merged
@fgiudici fgiudici mentioned this pull request Feb 15, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@giuseppe giuseppe giuseppe approved these changes

@runcom runcom Awaiting requested review from runcom

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

+1 more reviewer

@fgiudici fgiudici fgiudici approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@haircommander @openshift-cherrypick-robot @fgiudici @openshift-ci-robot @mrunalp @giuseppe @openshift-merge-robot