Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.19] gh actions: fix workflow #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 24, 2021
Merged

[1.19] gh actions: fix workflow #5307

openshift-merge-robot merged 1 commit into from
Sep 24, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Sep 14, 2021

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

/kind ci

none

@haircommander
gh actions: fix workflow
feddc81 
Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI labels Sep 14, 2021
@openshift-ci openshift-ci bot requested review from rhatdan and sboeuf September 14, 2021 13:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@haircommander
Copy link
Member Author

haircommander commented Sep 14, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 feddc81 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Sep 14, 2021 •
edited
Loading

Codecov Report

Merging #5307 (9b27c78) into release-1.19 (51841e9) will increase coverage by 2.16%.
The diff coverage is 21.68%.

❗ Current head 9b27c78 differs from pull request most recent head feddc81. Consider uploading reports for the commit feddc81 to get more accurate results

@@               Coverage Diff                @@
##           release-1.19    #5307      +/-   ##
================================================
+ Coverage         41.55%   43.71%   +2.16%     
================================================
  Files               115      115              
  Lines              8771     9792    +1021     
================================================
+ Hits               3645     4281     +636     
- Misses             4760     5128     +368     
- Partials            366      383      +17

@haircommander
Copy link
Member Author

haircommander commented Sep 14, 2021

@QiWang19 @wgahnagl @fgiudici PTAL

@QiWang19
Copy link
Member

QiWang19 commented Sep 15, 2021

LGTM

fgiudici
fgiudici approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgiudici, haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member Author

haircommander commented Sep 24, 2021

merge me please @wgahnagl @QiWang19 @fgiudici

@QiWang19
Copy link
Member

QiWang19 commented Sep 24, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7d25e5d into cri-o:release-1.19 Sep 24, 2021
@fgiudici fgiudici mentioned this pull request Feb 15, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan

@sboeuf sboeuf Awaiting requested review from sboeuf

1 more reviewer

@fgiudici fgiudici fgiudici approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@QiWang19 QiWang19

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haircommander @QiWang19 @fgiudici @openshift-merge-robot