Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update 'master' branch links to 'main' #5312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 16, 2021
Merged

Update 'master' branch links to 'main' #5312

openshift-merge-robot merged 1 commit into from
Sep 16, 2021

Conversation

@fgiudici
Copy link
Contributor

@fgiudici fgiudici commented Sep 15, 2021

Signed-off-by: Francesco Giudici [email protected]

What type of PR is this?

/kind other

What this PR does / why we need it:

Update the links referring to the master branch to point the main one.
Links are redirected from master to main when requested, so many changes in this PR do not fix actual issues.
Few changes are anyway required to fix smaller issues (e.g., update the link to display the CRI-O logo in our github markdown pages).

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category labels Sep 15, 2021
@openshift-ci openshift-ci bot requested a review from rhatdan September 15, 2021 16:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

Hi @fgiudici. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 15, 2021
@haircommander
Copy link
Member

haircommander commented Sep 15, 2021

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2021
@haircommander
Copy link
Member

haircommander commented Sep 15, 2021

/approve

LGTM, @QiWang19 @wgahnagl PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgiudici, haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #5312 (0991114) into main (1abf0d9) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0991114 differs from pull request most recent head 68c8989. Consider uploading reports for the commit 68c8989 to get more accurate results

@@            Coverage Diff             @@
##             main    #5312      +/-   ##
==========================================
+ Coverage   43.72%   43.74%   +0.01%     
==========================================
  Files         118      118              
  Lines       11722    11722              
==========================================
+ Hits         5126     5128       +2     
+ Misses       6109     6107       -2     
  Partials      487      487

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Sep 15, 2021

LGTM
I just wonder how we can broadcast this or not.

@mrunalp
Copy link
Member

mrunalp commented Sep 15, 2021

/retest

@haircommander
Copy link
Member

haircommander commented Sep 16, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@openshift-bot
Copy link

openshift-bot commented Sep 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Sep 16, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@fgiudici
Copy link
Contributor Author

fgiudici commented Sep 16, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2021

@fgiudici: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 68c8989 link /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 68c8989 link /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit cc15fa1 into cri-o:main Sep 16, 2021
@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Sep 16, 2021

🎆

@fgiudici fgiudici mentioned this pull request Feb 15, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/other Categorizes issue or PR as not clearly related to any existing kind/* category lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fgiudici @haircommander @TomSweeneyRedHat @mrunalp @openshift-bot @openshift-merge-robot