Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: set spec when dropping infra #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 15, 2021
Merged

server: set spec when dropping infra #5313

openshift-merge-robot merged 1 commit into from
Sep 15, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Sep 15, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix a bug where `inspectp` verbose output was incomplete for pods with a dropped infra container

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Sep 15, 2021
@openshift-ci openshift-ci bot requested a review from rhatdan September 15, 2021 17:06
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #5313 (61e0841) into main (1abf0d9) will decrease coverage by 0.01%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##             main    #5313      +/-   ##
==========================================
- Coverage   43.72%   43.71%   -0.02%     
==========================================
  Files         118      118              
  Lines       11722    11727       +5     
==========================================
+ Hits         5126     5127       +1     
- Misses       6109     6112       +3     
- Partials      487      488       +1

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 61e0841 link /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 61e0841 link /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Sep 15, 2021

Changes LGTM, but tests are still rumbling a bit.

mrunalp
mrunalp approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 049d494 into cri-o:main Sep 15, 2021
@haircommander
Copy link
Member Author

haircommander commented Sep 16, 2021

/cherry-pick release-1.22

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 16, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 16, 2021

@haircommander: new pull request created: #5315

Details

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haircommander @TomSweeneyRedHat @openshift-cherrypick-robot @mrunalp @openshift-merge-robot