Add support for latest NRI with extended scope. #5318
Conversation
|
Hi @klihub. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eee3422 to
cd80d68
Compare
cd80d68 to
e2715ee
Compare
a4efc8a to
2f478fc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5318 +/- ##
==========================================
- Coverage 43.79% 42.52% -1.28%
==========================================
Files 124 125 +1
Lines 14354 14898 +544
==========================================
+ Hits 6286 6335 +49
- Misses 7388 7875 +487
- Partials 680 688 +8 |
fdb0be6 to
ab1662b
Compare
Add support for enabling NRI support and for overriding the default NRI configuration using the command line or the configuration file. Signed-off-by: Krisztian Litkey <[email protected]>
Implement an NRI adaptation interface. This takes care of relaying requests/respones to/from NRI (external NRI plugins) as well as the logic of applying NRI-requested container adjustments/updates to actual containers. This interface is unaware of the internal details of how we represent pods and containers. The functions to deal with that, the 'NRI Domain' should be implemented by server.Server. Signed-off-by: Krisztian Litkey <[email protected]>
Implement the CRI 'NRI Domain', the functions our NRI interface needs to deal with CRI pods and containers. Hook NRI into CRI request processing. Signed-off-by: Krisztian Litkey <[email protected]>
Add a dedicated test client for testing NRI integration. The client provides some basic infra to act both as a CRI client and as one or more NRI plugins. It currently implements a basic set of NRI tests. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, klihub The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/override ci/prow/ci-rhel-integration |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-rhel-integration DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@klihub: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test kata-containers |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-e2e-conmonrs, ci/prow/ci-rhel-e2e DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Background
This PR is one in a set of 3 related PRs which aim to extend NRI beyond its current v1 capabilities. The primary goal of the proposed extension is to allow NRI to act as a common infrastructure for plugging in extensions to runtimes, and to allow these extensions to implement, among other things, vendor- and domain-specific custom logic for improved container configuration.
This particular PR prototypes integrating cri-o with this extended scope NRI.
Related PRs
The other related PRs in the set are:
For a more detailed description of the full proposal, please refer to this README.
Current State
This implementation is not considered to be ready for merging (hence the RFC title tag). While there are still things to fix, plenty of rough edges to improve, unit tests are missing, etc., we do consider it to be in a good enough shape for a review round. The conceptual idea and the goals behind this proposal should be clear enough, likewise the approach chosen and the related consequences and compromises. If you are interested in any of the related subjects, please chime in. Any and all feedback is welcome.
/kind feature