Thanks to visit codestin.com
Credit goes to github.com

Skip to content

release-notes: update to main #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Nov 9, 2021
Merged

release-notes: update to main #5445

openshift-merge-robot merged 2 commits into from
Nov 9, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Nov 8, 2021

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind ci

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI labels Nov 8, 2021
@openshift-ci openshift-ci bot requested review from umohnani8 and vrothberg November 8, 2021 15:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021 •
edited
Loading

Codecov Report

Merging #5445 (db4710d) into main (3943334) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head db4710d differs from pull request most recent head 0f99f33. Consider uploading reports for the commit 0f99f33 to get more accurate results

@@            Coverage Diff             @@
##             main    #5445      +/-   ##
==========================================
- Coverage   43.54%   43.52%   -0.02%     
==========================================
  Files         118      118              
  Lines       11864    11864              
==========================================
- Hits         5166     5164       -2     
- Misses       6205     6207       +2     
  Partials      493      493

sonatype-lift[bot]
sonatype-lift bot reviewed Nov 8, 2021
View reviewed changes
scripts/release-notes/release_notes.go
branch = "gh-pages"
tokenKey = "GITHUB_TOKEN"
branch = "gh-pages"
tokenKey = "GITHUB_TOKEN"
Copy link

@sonatype-lift sonatype-lift bot Nov 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G101: Potential hardcoded credentials
(at-me in a reply with help or ignore)

saschagrunert
saschagrunert approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's it, great catch!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

saschagrunert commented Nov 9, 2021

/retest-required

@openshift-bot
Copy link

openshift-bot commented Nov 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Nov 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021 •
edited
Loading

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 0f99f33 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 0f99f33 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Nov 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Nov 9, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 529276d into cri-o:main Nov 9, 2021
@haircommander
Copy link
Member Author

haircommander commented Nov 11, 2021

/cherry-pick release-1.22

@haircommander
Copy link
Member Author

haircommander commented Nov 11, 2021

/cherry-pick release-1.21

@haircommander
Copy link
Member Author

haircommander commented Nov 11, 2021

/cherry-pick release-1.20

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 11, 2021

@haircommander: new pull request created: #5453

Details

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 11, 2021

@haircommander: new pull request created: #5454

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Nov 11, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 11, 2021

@haircommander: new pull request created: #5455

Details

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@umohnani8 umohnani8 Awaiting requested review from umohnani8

@vrothberg vrothberg Awaiting requested review from vrothberg

+1 more reviewer

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haircommander @saschagrunert @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot