Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.22] oci: fix a couple of deadlocks in container stop code #5447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Nov 29, 2021
Merged

[1.22] oci: fix a couple of deadlocks in container stop code #5447

openshift-merge-robot merged 3 commits into from
Nov 29, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Nov 8, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

cherry-pick of #5433

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 8, 2021
@openshift-ci openshift-ci bot requested a review from rhatdan November 8, 2021 21:23
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021 •
edited
Loading

Codecov Report

Merging #5447 (7f48932) into release-1.22 (63ca938) will decrease coverage by 0.00%.
The diff coverage is 82.75%.

@@               Coverage Diff                @@
##           release-1.22    #5447      +/-   ##
================================================
- Coverage         43.68%   43.67%   -0.01%     
================================================
  Files               118      118              
  Lines             11751    11754       +3     
================================================
+ Hits               5133     5134       +1     
- Misses             6129     6131       +2     
  Partials            489      489

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 7f48932 link false /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 7f48932 link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander haircommander changed the title oci: fix a couple of deadlocks in container stop code [1.22] oci: fix a couple of deadlocks in container stop code Nov 9, 2021
@haircommander
Copy link
Member Author

haircommander commented Nov 9, 2021

related to https://bugzilla.redhat.com/show_bug.cgi?id=2021432

@saschagrunert
Copy link
Member

saschagrunert commented Nov 10, 2021

@haircommander do we plan to backport to 4.8?

@haircommander
Copy link
Member Author

haircommander commented Nov 10, 2021

yes I intend to bring this to all supported versions

saschagrunert
saschagrunert approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented Nov 29, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Nov 29, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 29, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8ed8e79 into cri-o:release-1.22 Nov 29, 2021
@haircommander
Copy link
Member Author

haircommander commented Nov 29, 2021

related to https://bugzilla.redhat.com/show_bug.cgi?id=2021432

@haircommander
Copy link
Member Author

haircommander commented Nov 29, 2021

/cherry-pick release-1.21

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 29, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 29, 2021

@haircommander: new pull request created: #5475

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haircommander @saschagrunert @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot