Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use iota #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kolyshkin wants to merge 2 commits into from
Closed

Use iota #5469

kolyshkin wants to merge 2 commits into from

Conversation

@kolyshkin
Copy link
Collaborator

@kolyshkin kolyshkin commented Nov 19, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Less hardcoded repeated numbers, more iotas!

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@kolyshkin
pkg/config: use iota
781b98f 
Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
server/cri/types: use iota
7db9b67 
Signed-off-by: Kir Kolyshkin <[email protected]>
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 19, 2021
@openshift-ci openshift-ci bot requested a review from rhatdan November 19, 2021 23:17
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2021
@kolyshkin kolyshkin mentioned this pull request Nov 19, 2021
Merged
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #5469 (652c5e6) into main (2874194) will not change coverage.
The diff coverage is n/a.

❗ Current head 652c5e6 differs from pull request most recent head 7db9b67. Consider uploading reports for the commit 7db9b67 to get more accurate results

@@           Coverage Diff           @@
##             main    #5469   +/-   ##
=======================================
  Coverage   43.52%   43.52%           
=======================================
  Files         118      118           
  Lines       11890    11890           
=======================================
  Hits         5175     5175           
  Misses       6220     6220           
  Partials      495      495

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2021

@kolyshkin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/kata-jenkins 7db9b67 link true /test kata-containers
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 20, 2021

Hmm, I am not sure why there are so many CI failures -- these changes are supposed to be non-disruptive, IOW they don't change anything but the way source code looks like.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2021

@kolyshkin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun 7db9b67 link true /test integration_crun
ci/openshift-jenkins/critest_fedora 7db9b67 link true /test critest_fedora
ci/openshift-jenkins/critest_rhel 7db9b67 link true /test critest_rhel
ci/openshift-jenkins/integration_fedora 7db9b67 link true /test integration_fedora
ci/kata-jenkins 7db9b67 link true /test kata-containers
ci/openshift-jenkins/integration_rhel 7db9b67 link true /test integration_rhel
ci/openshift-jenkins/integration_crun_cgroupv2 7db9b67 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_fedora 7db9b67 link true /test e2e_fedora
ci/openshift-jenkins/e2e_crun 7db9b67 link true /test e2e_crun
ci/openshift-jenkins/e2e_rhel 7db9b67 link true /test e2e_rhel
ci/prow/e2e-agnostic 7db9b67 link true /test e2e-agnostic
ci/prow/e2e-gcp 7db9b67 link true /test e2e-gcp
ci/openshift-jenkins/e2e_crun_cgroupv2 7db9b67 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

haircommander
haircommander reviewed Nov 22, 2021
View reviewed changes
server/cri/types/types.go

PodSandboxStateSandboxReady PodSandboxState = 0
PodSandboxStateSandboxNotReady PodSandboxState = 1
NamespaceModePOD NamespaceMode = iota
Copy link
Member

@haircommander haircommander Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is a good idea, but I think we should drop the types changes in favor of #5471

@kolyshkin
Copy link
Collaborator Author

kolyshkin commented Nov 22, 2021

this PR is a good idea, but I think we should drop the types changes in favor of #5471

Yes indeed! Thanks, closing.

@kolyshkin kolyshkin closed this Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolyshkin @openshift-ci-robot @haircommander