Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Drop intermediate CRI types #5471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 6, 2021
Merged

Drop intermediate CRI types #5471

openshift-merge-robot merged 1 commit into from
Dec 6, 2021

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Nov 22, 2021 •
edited
Loading

What type of PR is this?

/kind api-change

What this PR does / why we need it:

We now drop the intermediate types because the Kubelet fully supports the CRI v1 api. Therefore we stick to an unsafe memory cast for type conversion.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Drop support for `v1alpha2` Container Runtime Interface (CRI) and require `v1`.

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from haircommander November 22, 2021 09:47
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2021
@saschagrunert saschagrunert changed the title Drop support for CRI v1alpha2 WIP: Drop support for CRI v1alpha2 Nov 22, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2021
@saschagrunert saschagrunert force-pushed the cri-types branch 2 times, most recently from 7a76e01 to 4ce8ed2 Compare November 22, 2021 10:01
@saschagrunert saschagrunert changed the title WIP: Drop support for CRI v1alpha2 WIP: Drop intermediate CRI types Nov 22, 2021
@saschagrunert saschagrunert force-pushed the cri-types branch 4 times, most recently from bcb75b3 to abf9e6d Compare November 22, 2021 10:45
@codecov
Copy link

codecov bot commented Nov 22, 2021 •
edited
Loading

Codecov Report

Merging #5471 (600acb1) into main (1e2f62a) will decrease coverage by 0.09%.
The diff coverage is 58.92%.

❗ Current head 600acb1 differs from pull request most recent head 9667984. Consider uploading reports for the commit 9667984 to get more accurate results

@@            Coverage Diff             @@
##             main    #5471      +/-   ##
==========================================
- Coverage   43.49%   43.40%   -0.10%     
==========================================
  Files         120      118       -2     
  Lines       11909    11923      +14     
==========================================
- Hits         5180     5175       -5     
- Misses       6237     6250      +13     
- Partials      492      498       +6

@haircommander haircommander mentioned this pull request Nov 22, 2021
Closed
@saschagrunert saschagrunert force-pushed the cri-types branch 8 times, most recently from 50f0dd2 to c873b78 Compare November 22, 2021 15:54
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 23, 2021

/retest-required

@saschagrunert saschagrunert force-pushed the cri-types branch 7 times, most recently from 6515722 to f5a1d31 Compare December 1, 2021 08:45
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 1, 2021

/retest-required

2 similar comments
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 1, 2021

/retest-required

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 1, 2021

/retest-required

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 1, 2021

/test integration_fedora

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 1, 2021

/test integration_crun

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 2, 2021

/test integration_fedora
/test integration_crun

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 2, 2021

/retest

1 similar comment
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 2, 2021

/retest

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 3, 2021

/test integration_fedora
/test integration_crun

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 3, 2021

@cri-o/cri-o-maintainers PTAL

I suspect that both integration test suites are falling for quite some time and my changes are not related.

haircommander
haircommander reviewed Dec 3, 2021
View reviewed changes
@saschagrunert
Drop intermediate CRI types
9667984 
We now drop the intermediate types because the Kubelet fully supports
the CRI `v1` api. Therefore we stick to an unsafe memory cast for type
conversion.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 6, 2021

/test integration_crun

2 similar comments
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 6, 2021

/test integration_crun

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 6, 2021

/test integration_crun

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 6, 2021

@haircommander PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2021

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 9667984 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 9667984 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Dec 6, 2021

/lgtm

thanks for working on this, seemed like a pain haha

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit d57d291 into cri-o:main Dec 6, 2021
@saschagrunert saschagrunert deleted the cri-types branch December 6, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haircommander haircommander haircommander left review comments

@fidencio fidencio Awaiting requested review from fidencio fidencio is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

3 participants

@saschagrunert @haircommander @openshift-merge-robot