Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update go to 1.17 in go.mod #5473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rockmenjack wants to merge 1 commit into from
Closed

update go to 1.17 in go.mod #5473

rockmenjack wants to merge 1 commit into from

Conversation

@rockmenjack
Copy link
Contributor

@rockmenjack rockmenjack commented Nov 24, 2021 •
edited by haircommander
Loading

Signed-off-by: rockmenjack [email protected]

/kind dependency-change

What this PR does / why we need it:

golang 1.15 can no longer compile cri-o because kubernetes/client-go@ef1d5d2 has introduced io/fs which comes with golang 1.17

# make binaries
mkdir -p "/root/cri-o/_output/src/github.com/cri-o"
ln -s "/root/cri-o" "/root/cri-o/_output/src/github.com/cri-o/cri-o"
touch "/root/cri-o/_output/.gopathok"
go build -trimpath  -ldflags '-s -w -X github.com/cri-o/cri-o/internal/pkg/criocli.DefaultsPath="" -X github.com/cri-o/cri-o/internal/version.buildDate='2021-11-24T03:40:58Z' -X github.com/cri-o/cri-o/internal/version.gitCommit=2811bd6afea913deb176acd667b904978c273e81 -X github.com/cri-o/cri-o/internal/version.gitTreeState=clean ' -tags "containers_image_ostree_stub  exclude_graphdriver_btrfs btrfs_noversion exclude_graphdriver_devicemapper libdm_no_deferred_remove    " -o bin/crio github.com/cri-o/cri-o/cmd/crio
vendor/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics.go:21:2: cannot find package "." in:
        /root/cri-o/vendor/io/fs
make: *** [Makefile:172: bin/crio] Error 1

Which issue(s) this PR fixes:

this PR just update go.mod to reflect dependency on golang 1.17+

none

@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2021

Hi @rockmenjack. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 24, 2021
@openshift-ci openshift-ci bot requested a review from vrothberg November 24, 2021 05:09
@codecov
Copy link

codecov bot commented Nov 24, 2021 •
edited
Loading

Codecov Report

Merging #5473 (915925e) into main (a9c23ff) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 915925e differs from pull request most recent head 965b4e9. Consider uploading reports for the commit 965b4e9 to get more accurate results

@@            Coverage Diff             @@
##             main    #5473      +/-   ##
==========================================
- Coverage   43.23%   43.22%   -0.01%     
==========================================
  Files         123      123              
  Lines       12214    12214              
==========================================
- Hits         5281     5280       -1     
- Misses       6425     6426       +1     
  Partials      508      508

@haircommander
Copy link
Member

haircommander commented Nov 29, 2021

/ok-to-test
/approve

LGTM, thank you @rockmenjack

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, rockmenjack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@rockmenjack
Copy link
Contributor Author

rockmenjack commented Nov 30, 2021

/retest-required

1 similar comment
@rockmenjack
Copy link
Contributor Author

rockmenjack commented Dec 3, 2021

/retest-required

@rockmenjack
Copy link
Contributor Author

rockmenjack commented Dec 27, 2021

/retest

haircommander
haircommander reviewed Jan 4, 2022
View reviewed changes
go.mod Outdated
@@ -1,4 +1,4 @@
go 1.15
go 1.16
Copy link
Member

@haircommander haircommander Jan 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

embarrassingly (on the reviewers' end for not merging this earlier), it's been so long that we actually don't build with anything less than 1.17 now. could you update it @rockmenjack ? also, thanks for your patience here

@rockmenjack rockmenjack force-pushed the fix_go_mod_go_version branch from 2811bd6 to 3ff0934 Compare January 16, 2022 15:55
@rockmenjack
Copy link
Contributor Author

rockmenjack commented Jan 16, 2022

/retest-required

1 similar comment
@rockmenjack
Copy link
Contributor Author

rockmenjack commented Jan 18, 2022

/retest-required

@rockmenjack rockmenjack changed the title update go to 1.16 in go.mod update go to 1.17 in go.mod Jan 18, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2022
@rockmenjack rockmenjack force-pushed the fix_go_mod_go_version branch 2 times, most recently from ad390bd to d62c4b4 Compare January 18, 2022 03:05
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2022
@rockmenjack
Copy link
Contributor Author

rockmenjack commented Jan 18, 2022

/retest-required

@haircommander
Copy link
Member

haircommander commented Jan 18, 2022

/retest-required

LGTM @cri-o/cri-o-maintainers PTAL

@QiWang19
Copy link
Member

QiWang19 commented Jan 18, 2022

/lgtm

@openshift-bot
Copy link

openshift-bot commented Jan 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Jan 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 19, 2022
@openshift-bot
Copy link

openshift-bot commented Jan 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

openshift-bot commented Jan 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jan 19, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member

haircommander commented Jan 20, 2022

/hold

to figure out openshift failures

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2022
@haircommander
Copy link
Member

haircommander commented Jan 20, 2022

/retest-required

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2022
@rockmenjack
update go to 1.17 in go.mod
965b4e9 
Signed-off-by: rockmenjack <[email protected]>
@rockmenjack rockmenjack force-pushed the fix_go_mod_go_version branch from d62c4b4 to 965b4e9 Compare January 26, 2022 08:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@rockmenjack: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_fedora 965b4e9 link true /test integration_fedora
ci/openshift-jenkins/integration_crun_cgroupv2 965b4e9 link false /test integration_cgroupv2
ci/openshift-jenkins/integration_rhel 965b4e9 link true /test integration_rhel
ci/prow/e2e-agnostic 965b4e9 link true /test e2e-agnostic
ci/openshift-jenkins/e2e_crun_cgroupv2 965b4e9 link false /test e2e_cgroupv2
ci/prow/e2e-gcp 965b4e9 link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Jan 26, 2022

sorry @rockmenjack one more merge conflict. Once you fix, and we sanity check the PR against most tests, I'll force merge. Thank you again for your patience

@haircommander
Copy link
Member

haircommander commented Jan 26, 2022

(also feel free to give up on this PR, the CRI-O maintainer team could take it over if it's too much trouble)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2022

@rockmenjack: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2022
@rockmenjack
Copy link
Contributor Author

rockmenjack commented Jan 27, 2022

(also feel free to give up on this PR, the CRI-O maintainer team could take it over if it's too much trouble)

yeah, looks like it is better to hand it over to maintainer team

@rockmenjack rockmenjack deleted the fix_go_mod_go_version branch January 27, 2022 02:56
@QiWang19 QiWang19 mentioned this pull request Jan 27, 2022
Merged
@haircommander
Copy link
Member

haircommander commented Jan 27, 2022

thank you for your attempt! I really appreciate your patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haircommander haircommander haircommander left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@QiWang19 QiWang19

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/dependency-change Categorizes issue or PR as related to changing dependencies needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rockmenjack @haircommander @QiWang19 @openshift-bot