Fix runtime panic on stats server shutdown #5474
Conversation
It may be possible that the stats servers `Shutdown()` get called twice during CRI-O stop. To avoid calling `close()` on an already closed channel, we now internally track if the stats server is still running or not. Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #5474 +/- ##
==========================================
- Coverage 43.48% 43.48% -0.01%
==========================================
Files 120 120
Lines 11904 11904
==========================================
- Hits 5177 5176 -1
- Misses 6233 6234 +1
Partials 494 494 |
|
/retest-required |
|
🙈 oopsies |
|
good catch, thanks 😅 |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@saschagrunert: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
It may be possible that the stats servers
Shutdown()get called twiceduring CRI-O stop. To avoid calling
close()on an already closedchannel, we now internally track if the stats server is still running or
not.
Which issue(s) this PR fixes:
Introduced in #5427
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?