Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.22] server: close namespaces on sandbox stop #5477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 14, 2021
Merged

[release-1.22] server: close namespaces on sandbox stop #5477

openshift-merge-robot merged 1 commit into from
Dec 14, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 29, 2021

This is an automated cherry-pick of #5336

/assign haircommander

Move namespace cleanup from sandbox stop to sandbox remove. This allows veth entries in the network namespaces of pods to be cleaned up earlier

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 29, 2021
Merged
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 29, 2021
@haircommander
Copy link
Member

haircommander commented Nov 29, 2021

/cherry-pick release-1.21

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Nov 29, 2021

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #5477 (1fcda25) into release-1.22 (8ed8e79) will increase coverage by 0.00%.
The diff coverage is 59.37%.

@@              Coverage Diff              @@
##           release-1.22    #5477   +/-   ##
=============================================
  Coverage         43.75%   43.76%           
=============================================
  Files               118      118           
  Lines             11770    11775    +5     
=============================================
+ Hits               5150     5153    +3     
- Misses             6131     6135    +4     
+ Partials            489      487    -2

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@rphillips
Copy link
Contributor

rphillips commented Dec 9, 2021

/hold

For further review

@rphillips
Copy link
Contributor

rphillips commented Dec 9, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2021
@mrunalp
Copy link
Member

mrunalp commented Dec 9, 2021

/hold
possible regression

@haircommander
Copy link
Member

haircommander commented Dec 13, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@haircommander
Copy link
Member

haircommander commented Dec 13, 2021

/lgtm cancel

didn't see those notes

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@haircommander
Copy link
Member

haircommander commented Dec 13, 2021

just checked in, no regression has been found here

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 13, 2021
@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 1fcda25 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 1fcda25 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Dec 14, 2021

/override ci/openshift-jenkins/integration_crun

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun

Details

In response to this:

/override ci/openshift-jenkins/integration_crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit aeeadca into cri-o:release-1.22 Dec 14, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 14, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Dec 14, 2021

@haircommander: new pull request created: #5502

Details

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@haircommander haircommander Awaiting requested review from haircommander

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @haircommander @rphillips @mrunalp @openshift-bot @saschagrunert @openshift-merge-robot