Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.22] workloads: fix if resources are empty #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 3, 2021
Merged

[1.22] workloads: fix if resources are empty #5486

openshift-merge-robot merged 1 commit into from
Dec 3, 2021
+23 −0

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Dec 3, 2021

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix a segfault if a workload is configured without the resources table

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Dec 3, 2021
@openshift-ci openshift-ci bot requested a review from fidencio December 3, 2021 14:56
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #5486 (9f0dae6) into release-1.22 (8ed8e79) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.22    #5486      +/-   ##
================================================
- Coverage         43.75%   43.74%   -0.01%     
================================================
  Files               118      118              
  Lines             11770    11774       +4     
================================================
+ Hits               5150     5151       +1     
- Misses             6131     6134       +3     
  Partials            489      489

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021 •
edited
Loading

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 9f0dae6 link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mrunalp
mrunalp approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
@openshift-bot
Copy link

openshift-bot commented Dec 3, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Dec 3, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Dec 3, 2021

LGTM

@openshift-merge-robot openshift-merge-robot merged commit e059965 into cri-o:release-1.22 Dec 3, 2021
@openshift-ci openshift-ci bot mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@fidencio fidencio Awaiting requested review from fidencio

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haircommander @openshift-bot @TomSweeneyRedHat @mrunalp @openshift-merge-robot