Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump Kubernetes to v1.23.0 #5489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 14, 2021
Merged

Bump Kubernetes to v1.23.0 #5489

openshift-merge-robot merged 1 commit into from
Dec 14, 2021

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Dec 8, 2021

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

Bump vendored Kubernetes to the latest release.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 8, 2021
@saschagrunert saschagrunert added this to the 1.23 milestone Dec 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from giuseppe December 8, 2021 08:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021 •
edited
Loading

Codecov Report

Merging #5489 (6f4e7bf) into main (daab4d1) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #5489   +/-   ##
=======================================
  Coverage   43.25%   43.25%           
=======================================
  Files         120      120           
  Lines       12001    12003    +2     
=======================================
+ Hits         5191     5192    +1     
- Misses       6315     6316    +1     
  Partials      495      495

@saschagrunert saschagrunert force-pushed the k8s-bump branch 2 times, most recently from 89f7fc4 to c765ba5 Compare December 8, 2021 09:57
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 8, 2021

/retest-required

3 similar comments
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 9, 2021

/retest-required

@mrunalp
Copy link
Member

mrunalp commented Dec 10, 2021

/retest-required

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 13, 2021

/retest-required

@haircommander
Copy link
Member

haircommander commented Dec 13, 2021

I believe you need to apply

**diff --git a/contrib/test/ci/cri-o.spec b/contrib/test/ci/cri-o.spec
index c723830ac1..7265b62516 100644
--- a/contrib/test/ci/cri-o.spec
+++ b/contrib/test/ci/cri-o.spec
@@ -13,7 +13,7 @@
 
 %if ! 0%{?centos} && 0%{?rhel}
 # Golang minor version
-%global gominver 16
+%global gominver 17
 %define gobuild(o:) scl enable go-toolset-1.%{gominver} -- go build -buildmode pie -compiler gc -tags="rpm_crashtraceback no_openssl ${BUILDTAGS:-}" -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \\n') -extldflags '%__global_ldflags'" -a -v -x %{?**};
 %else
 %define gobuild(o:) go build -buildmode pie -compiler gc -tags="rpm_crashtraceback no_openssl ${BUILDTAGS:-}" -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \\n') -extldflags '%__global_ldflags'" -a -v -x %{?**};

to fix openshift e2e

@saschagrunert
Bump Kubernetes to v1.23.0
6f4e7bf 
Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 14, 2021

to fix openshift e2e

Thank you! I bumped the go version and rebased.

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 14, 2021

/retest-required

@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 14, 2021

@fidencio it looks like that kata is broken across several PRs:

09:07:47 Failed at 578: bash ${script_dir}/../../../ci/install_libseccomp.sh "${libseccomp_install_dir}" "${gperf_install_dir}"
09:07:48 make: *** [Makefile:93: /tmp/jenkins/workspace/kata-containers-2-crio-PR/go/src/github.com/kata-containers/kata-containers/tools/osbuilder/.ubuntu_rootfs.done] Error 7
09:07:48 [install_kata_image.sh:50] ERROR: sudo -E USE_DOCKER= DISTRO=ubuntu make -e image
09:07:48 [install_kata.sh:22] ERROR: .ci/install_kata_image.sh

May I ask you to give it a look?

@saschagrunert saschagrunert mentioned this pull request Dec 14, 2021
Merged
@saschagrunert
Copy link
Member Author

saschagrunert commented Dec 14, 2021

Okay I think we have to switch the image base as well: openshift/release#24591

@haircommander
Copy link
Member

haircommander commented Dec 14, 2021

/retest

@haircommander
Copy link
Member

haircommander commented Dec 14, 2021

/test integration_rhel
/override ci/openshift-jenkins/integration_crun
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun

Details

In response to this:

/test integration_rhel
/override ci/openshift-jenkins/integration_crun
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021 •
edited
Loading

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 6f4e7bf link false /test e2e_cgroupv2
ci/openshift-jenkins/integration_crun_cgroupv2 6f4e7bf link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Dec 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 116b6ce into cri-o:main Dec 14, 2021
@saschagrunert saschagrunert deleted the k8s-bump branch December 14, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@giuseppe giuseppe Awaiting requested review from giuseppe

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

5 participants

@saschagrunert @mrunalp @haircommander @openshift-bot @openshift-merge-robot