Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: fix selinux test failures #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 13, 2021
Merged

test: fix selinux test failures #5400

openshift-merge-robot merged 1 commit into from
Oct 13, 2021

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Oct 12, 2021

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

/kind ci

none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/ci Categorizes issue or PR as related to CI dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 12, 2021
@openshift-ci openshift-ci bot requested review from giuseppe and sameo October 12, 2021 17:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021 •
edited
Loading

Codecov Report

Merging #5400 (385e957) into main (90d9f9c) will not change coverage.
The diff coverage is n/a.

❗ Current head 385e957 differs from pull request most recent head c0a8f33. Consider uploading reports for the commit c0a8f33 to get more accurate results

@@           Coverage Diff           @@
##             main    #5400   +/-   ##
=======================================
  Coverage   43.72%   43.72%           
=======================================
  Files         118      118           
  Lines       11749    11749           
=======================================
  Hits         5137     5137           
  Misses       6124     6124           
  Partials      488      488

@haircommander haircommander force-pushed the debug-selinux-test branch 2 times, most recently from 72aedce to 7055bb6 Compare October 12, 2021 21:00
@haircommander haircommander changed the title WIP: test: debug selinux test failures test: fix selinux test failures Oct 12, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2021
@haircommander
test: fix selinux test failures
c0a8f33 
RHEL/CentOS 7's container-selinux package replaces container_file_t with svirt_sandbox_file_t
under the hood. This causes the annotation to not work correctly.

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
Copy link
Member Author

haircommander commented Oct 12, 2021

/retest

@haircommander
Copy link
Member Author

haircommander commented Oct 12, 2021

@cri-o/cri-o-maintainers PTAL

saschagrunert
saschagrunert approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2021 •
edited
Loading

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 c0a8f33 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 c0a8f33 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Oct 13, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@saschagrunert saschagrunert mentioned this pull request Oct 13, 2021
Merged
@openshift-merge-robot openshift-merge-robot merged commit 25c9823 into cri-o:main Oct 13, 2021
@openshift-ci openshift-ci bot mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@giuseppe giuseppe Awaiting requested review from giuseppe

@sameo sameo Awaiting requested review from sameo

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haircommander @openshift-bot @saschagrunert @openshift-merge-robot