Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.21] server: do not wait forever on conmon cgroup move fail #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 14, 2021
Merged

[release-1.21] server: do not wait forever on conmon cgroup move fail #5407

openshift-merge-robot merged 1 commit into from
Oct 14, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 14, 2021

This is an automated cherry-pick of #5309

/assign haircommander

fix a bug where CRI-O waits forever on a conmon process that will not stop

@haircommander
server: don't wait forever on conmon cgroup move fail
fc5f562 
If we haven't signaled on the stop pipe, then conmon will be sitting waiting to be told to start
Instead, we need to kill the process.

Signed-off-by: Peter Hunt <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 14, 2021
Merged
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 14, 2021
@openshift-ci openshift-ci bot requested review from nalind and umohnani8 October 14, 2021 15:36
@haircommander haircommander changed the title [release-1.21] [release-1.22] server: do not wait forever on conmon cgroup move fail [release-1.21] server: do not wait forever on conmon cgroup move fail Oct 14, 2021
mrunalp
mrunalp approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #5407 (fc5f562) into release-1.21 (e34bf50) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.21    #5407      +/-   ##
================================================
+ Coverage         44.95%   44.97%   +0.01%     
================================================
  Files               107      107              
  Lines             10966    10966              
================================================
+ Hits               4930     4932       +2     
+ Misses             5555     5553       -2     
  Partials            481      481

@openshift-bot
Copy link

openshift-bot commented Oct 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

openshift-bot commented Oct 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 14, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2021 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 fc5f562 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 fc5f562 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Oct 14, 2021

/override ci/openshift-jenkins/integration_rhel

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2021

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_rhel

Details

In response to this:

/override ci/openshift-jenkins/integration_rhel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e87e050 into cri-o:release-1.21 Oct 14, 2021
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@nalind nalind Awaiting requested review from nalind

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@mrunalp mrunalp

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-bot @haircommander @mrunalp @openshift-merge-robot