oci: set conmon cpuset to infra_ctr_cpuset #5414

haircommander · 2021-10-19T21:22:22Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Now, if infra_ctr_cpuset is configured, conmon is put in the same cpuset

codecov · 2021-10-19T21:26:09Z

Codecov Report

Merging #5414 (2c7434e) into main (fc844e4) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

❗ Current head 2c7434e differs from pull request most recent head 5d3c5a6. Consider uploading reports for the commit 5d3c5a6 to get more accurate results

@@            Coverage Diff             @@
##             main    #5414      +/-   ##
==========================================
- Coverage   43.27%   43.26%   -0.02%     
==========================================
  Files         120      120              
  Lines       11995    11998       +3     
==========================================
  Hits         5191     5191              
- Misses       6309     6312       +3     
  Partials      495      495

haircommander · 2021-10-19T23:46:10Z

/retest-required

TomSweeneyRedHat · 2021-10-20T18:34:47Z

LGTM
and it looks like a lot of happy green test buttons.

haircommander · 2021-11-30T16:50:03Z

/retest

Signed-off-by: Peter Hunt <[email protected]>

mrunalp · 2021-12-13T21:16:03Z

internal/oci/oci_linux.go


+	// First, set the cpuset as the one for the infra container.
+	// This should be overridden if specified in a workload.
+	if r.config.InfraCtrCPUSet != "" && r.config.ConmonCgroup == utils.PodCgroupName {


Why do we need the second check?

updated with a comment--it's possible a user has configured the cpuset of the conmon cgroup

Signed-off-by: Peter Hunt <[email protected]>

haircommander · 2021-12-14T00:43:46Z

/override ci/openshift-jenkins/integration_crun

openshift-ci · 2021-12-14T00:43:48Z

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun

Details

In response to this:

/override ci/openshift-jenkins/integration_crun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cynepco3hahue · 2021-12-14T07:48:19Z

/lgtm
It is important to say that it is only part of the solution, we still have a small window when the conmon process runs on top of all CPUs, and it should be fixed once we will have clone3 functionality under the OS.

openshift-ci · 2021-12-14T07:48:20Z

@cynepco3hahue: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm
It is important to say that it is only part of the solution, we still have a small window when the conmon process runs on top of all CPUs, and it should be fixed once we will have clone3 functionality under the OS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saschagrunert

LGTM

mrunalp

/lgtm

openshift-ci · 2021-12-16T01:31:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-12-16T02:43:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T02:55:11Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T03:07:12Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T06:10:37Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T06:23:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T06:36:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T07:02:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-12-16T07:21:14Z

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2	`5d3c5a6`	link	false	`/test e2e_cgroupv2`
ci/openshift-jenkins/integration_crun_cgroupv2	`5d3c5a6`	link	false	`/test integration_cgroupv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-12-16T08:20:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-12-16T08:59:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

haircommander requested review from mrunalp and runcom as code owners October 19, 2021 21:22

openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 19, 2021

openshift-ci bot requested review from kolyshkin and umohnani8 October 19, 2021 21:22

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2021

haircommander force-pushed the conmon-cpuset branch from f9ea65c to e7eb6d6 Compare October 19, 2021 21:25

openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 19, 2021

haircommander force-pushed the conmon-cpuset branch 2 times, most recently from e83c733 to 5c5cd9f Compare October 19, 2021 22:00

saschagrunert approved these changes Oct 20, 2021

View reviewed changes

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2021

haircommander force-pushed the conmon-cpuset branch from 5c5cd9f to 53be654 Compare November 1, 2021 14:17

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021

haircommander added this to the 1.23 milestone Nov 30, 2021

haircommander force-pushed the conmon-cpuset branch from 53be654 to 3578206 Compare November 30, 2021 16:45

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2021

stop using hardcoded "pod" const

99e93ee

Signed-off-by: Peter Hunt <[email protected]>

haircommander force-pushed the conmon-cpuset branch from 3578206 to 69041a6 Compare December 13, 2021 20:37

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2021

mrunalp reviewed Dec 13, 2021

View reviewed changes

haircommander force-pushed the conmon-cpuset branch from 69041a6 to 19c716d Compare December 13, 2021 22:00

oci: put conmon in infra ctr cpuset if it is in the pod cgroup

5d3c5a6

Signed-off-by: Peter Hunt <[email protected]>

haircommander force-pushed the conmon-cpuset branch from 19c716d to 5d3c5a6 Compare December 13, 2021 22:02

saschagrunert approved these changes Dec 14, 2021

View reviewed changes

mrunalp approved these changes Dec 16, 2021

View reviewed changes

openshift-ci bot assigned mrunalp Dec 16, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021

openshift-merge-robot merged commit ff7dfeb into cri-o:main Dec 16, 2021

oci: set conmon cpuset to infra_ctr_cpuset #5414

oci: set conmon cpuset to infra_ctr_cpuset #5414

Uh oh!

Conversation

haircommander commented Oct 19, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

codecov bot commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

haircommander commented Oct 19, 2021

Uh oh!

TomSweeneyRedHat commented Oct 20, 2021

Uh oh!

haircommander commented Nov 30, 2021

Uh oh!

mrunalp Dec 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haircommander Dec 13, 2021

Choose a reason for hiding this comment

Uh oh!

haircommander commented Dec 14, 2021

Uh oh!

openshift-ci bot commented Dec 14, 2021

Uh oh!

cynepco3hahue commented Dec 14, 2021

Uh oh!

openshift-ci bot commented Dec 14, 2021

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

mrunalp left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Dec 16, 2021

Uh oh!

openshift-bot commented Dec 16, 2021

Uh oh!

openshift-bot commented Dec 16, 2021

Uh oh!

openshift-bot commented Dec 16, 2021

Uh oh!

openshift-bot commented Dec 16, 2021

Uh oh!

openshift-bot commented Dec 16, 2021

Uh oh!

openshift-bot commented Dec 16, 2021

Uh oh!

openshift-bot commented Dec 16, 2021

Uh oh!

openshift-ci bot commented Dec 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Dec 16, 2021

Uh oh!

openshift-bot commented Dec 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov bot commented Oct 19, 2021 •

edited

Loading

mrunalp Dec 13, 2021 •

edited

Loading

openshift-ci bot commented Dec 16, 2021 •

edited

Loading