Workaround on new CA from Ubuntu. Also minor documentation improvemen… #5420

thanos1983 · 2021-10-22T17:03:11Z

…t on how to deploy metrics without the need to download the repo.

Signed-off-by: Athanasios Garyfalos [email protected]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

…t on how to deploy metrics without the need to download the repo. Signed-off-by: Athanasios Garyfalos <[email protected]>

openshift-ci · 2021-10-22T17:03:13Z

@thanos1983: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-10-22T17:03:20Z

Hi @thanos1983. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

thanos1983 · 2021-10-22T17:04:01Z

@haircommander thanks a lot @haircommander.

I hope this time I got it straight :)

Have a nice weekend.

BR / Thanos

codecov · 2021-10-22T17:06:55Z

Codecov Report

Merging #5420 (038547b) into main (35d1be8) will decrease coverage by 0.28%.
The diff coverage is 48.82%.

@@            Coverage Diff             @@
##             main    #5420      +/-   ##
==========================================
- Coverage   43.78%   43.50%   -0.29%     
==========================================
  Files         118      118              
  Lines       11721    11829     +108     
==========================================
+ Hits         5132     5146      +14     
- Misses       6102     6191      +89     
- Partials      487      492       +5

saschagrunert

/ok-to-test

LGTM

openshift-ci · 2021-10-25T06:44:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, thanos1983

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander · 2021-10-25T13:58:11Z

tutorials/install-distro.md

 curl -L https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/$OS/Release.key | gpg --dearmor -o /usr/share/keyrings/libcontainers-archive-keyring.gpg
 curl -L https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable:/cri-o:/$VERSION/$OS/Release.key | gpg --dearmor -o /usr/share/keyrings/libcontainers-crio-archive-keyring.gpg

-apt-get update


shoot I think we still need this.

can you add it back, commit the changes, and squash the commits together with
git rebase -i upstream/main and then change the pick of the second line to s and quit the editor? then force push the branch

TomSweeneyRedHat · 2021-10-25T15:07:02Z

tutorials/install-distro.md

-sudo dnf module enable cri-o:$VERSION
-sudo dnf install cri-o
+dnf module enable cri-o:$VERSION
+dnf install -y cri-o


I personally like having the -y in the docs, but I have received a lot of negative feedback in the past from people who have security or disk space concerns with it.

I personally like having the -y in the docs, but I have received a lot of negative feedback in the past from people who have security or disk space concerns with it.

I will agree with @TomSweeneyRedHat. Removing -y and adding apt upgrade. On my case simple apt update does not work.

I hope now is okay :) @haircommander to verify :)

TomSweeneyRedHat · 2021-10-25T15:07:56Z

LGTM once @haircommander 's comment is settled.

…t on how to deploy metrics without the need to download the repo. Signed-off-by: Athanasios Garyfalos <[email protected]>

…368-adding-docs Signed-off-by: Athanasios Garyfalos <[email protected]>

haircommander · 2021-10-26T13:20:28Z

tutorials/install-distro.md

 curl -L -o /etc/yum.repos.d/devel:kubic:libcontainers:stable.repo https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/$OS/devel:kubic:libcontainers:stable.repo
 curl -L -o /etc/yum.repos.d/devel:kubic:libcontainers:stable:cri-o:$VERSION.repo https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable:cri-o:$VERSION/$OS/devel:kubic:libcontainers:stable:cri-o:$VERSION.repo
-yum install cri-o
+yum install -y cri-o


one more nit: if we drop the other -ys, then we should drop this one as well

one more nit: if we drop the other -ys, then we should drop this one as well

@haircommander I missed this, thanks for noticing :)

…t on how to deploy metrics without the need to download the repo. Signed-off-by: Athanasios Garyfalos <[email protected]>

…368-adding-docs

openshift-ci · 2021-10-27T08:14:07Z

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

038547b Merge branch '5368-adding-docs' of github.com:thanos1983/cri-o into 5368-adding-docs

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

thanos1983 · 2021-11-15T13:54:38Z

/retest

thanos1983 · 2021-11-15T13:54:51Z

@haircommander follow up?

thanos1983 · 2021-11-15T14:13:23Z

/retest

openshift-ci-robot · 2021-11-15T14:20:46Z

@thanos1983: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/kata-jenkins	`038547b`	link	true	`/test kata-containers`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2021-11-15T18:24:07Z

@thanos1983: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/kata-jenkins	`038547b`	link	true	`/test kata-containers`
ci/openshift-jenkins/integration_crun_cgroupv2	`038547b`	link	false	`/test integration_cgroupv2`
ci/openshift-jenkins/e2e_crun_cgroupv2	`038547b`	link	false	`/test e2e_cgroupv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

haircommander · 2021-11-15T20:28:01Z

sorry @thanos1983 we can't merge it with all of the merge commits in therre. have you tried using git rebase to remove/squash them?

Workaround on new CA from Ubuntu. Also minor documentation improvemen…

afc1a83

…t on how to deploy metrics without the need to download the repo. Signed-off-by: Athanasios Garyfalos <[email protected]>

thanos1983 requested review from mrunalp and runcom as code owners October 22, 2021 17:03

openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 22, 2021

openshift-ci bot requested a review from umohnani8 October 22, 2021 17:03

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2021

thanos1983 mentioned this pull request Oct 22, 2021

5368/Adding-documentation-for-certificates Adding documentation for C… #5374

Closed

saschagrunert approved these changes Oct 25, 2021

View reviewed changes

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2021

haircommander reviewed Oct 25, 2021

View reviewed changes

TomSweeneyRedHat reviewed Oct 25, 2021

View reviewed changes

Athanasios Garyfalos added 2 commits October 26, 2021 11:31

Workaround on new CA from Ubuntu. Also minor documentation improvemen…

088da54

…t on how to deploy metrics without the need to download the repo. Signed-off-by: Athanasios Garyfalos <[email protected]>

Merge branch '5368-adding-docs' of github.com:thanos1983/cri-o into 5…

31c43d6

…368-adding-docs Signed-off-by: Athanasios Garyfalos <[email protected]>

thanos1983 requested review from haircommander and saschagrunert October 26, 2021 09:35

haircommander reviewed Oct 26, 2021

View reviewed changes

Athanasios Garyfalos added 2 commits October 27, 2021 10:11

Workaround on new CA from Ubuntu. Also minor documentation improvemen…

ef90200

…t on how to deploy metrics without the need to download the repo. Signed-off-by: Athanasios Garyfalos <[email protected]>

Merge branch '5368-adding-docs' of github.com:thanos1983/cri-o into 5…

038547b

…368-adding-docs

openshift-ci bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 27, 2021

thanos1983 requested a review from haircommander October 27, 2021 08:14

thanos1983 closed this Dec 14, 2021

thanos1983 deleted the 5368-adding-docs branch December 14, 2021 11:18

Workaround on new CA from Ubuntu. Also minor documentation improvemen… #5420

Workaround on new CA from Ubuntu. Also minor documentation improvemen… #5420

Uh oh!

Conversation

thanos1983 commented Oct 22, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci bot commented Oct 22, 2021

Uh oh!

openshift-ci bot commented Oct 22, 2021

Uh oh!

thanos1983 commented Oct 22, 2021

Uh oh!

codecov bot commented Oct 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Oct 25, 2021

Uh oh!

haircommander Oct 25, 2021

Choose a reason for hiding this comment

Uh oh!

TomSweeneyRedHat Oct 25, 2021

Choose a reason for hiding this comment

Uh oh!

thanos1983 Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

TomSweeneyRedHat commented Oct 25, 2021

Uh oh!

haircommander Oct 26, 2021

Choose a reason for hiding this comment

Uh oh!

thanos1983 Oct 27, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Oct 27, 2021

Uh oh!

thanos1983 commented Nov 15, 2021

Uh oh!

thanos1983 commented Nov 15, 2021

Uh oh!

thanos1983 commented Nov 15, 2021

Uh oh!

openshift-ci-robot commented Nov 15, 2021

Uh oh!

openshift-ci bot commented Nov 15, 2021

Uh oh!

haircommander commented Nov 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Oct 22, 2021 •

edited

Loading