-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release-1.22] Bug 2020729: fix override storage options from storage.conf #5437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.22] Bug 2020729: fix override storage options from storage.conf #5437
Conversation
Fix https://bugzilla.redhat.com/show_bug.cgi?id=2012838 Merge in the storage_option from drop-in crio.conf to the storage.conf, do not override the configs from storage.conf. The override leads to configuration of containerruntimeconfig not working. Signed-off-by: Qi Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-1.22 #5437 +/- ##
================================================
+ Coverage 43.68% 43.74% +0.05%
================================================
Files 118 118
Lines 11751 11767 +16
================================================
+ Hits 5133 5147 +14
- Misses 6130 6131 +1
- Partials 488 489 +1 |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This is an automated cherry-pick of #5423
Fix: https://bugzilla.redhat.com/show_bug.cgi?id=2020729
/assign haircommander