Thanks to visit codestin.com
Credit goes to github.com

Skip to content

pkg/container: fix container device GID fallback. #5548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 18, 2022
Merged

pkg/container: fix container device GID fallback. #5548

openshift-merge-robot merged 1 commit into from
Jan 18, 2022

Conversation

@klihub
Copy link
Contributor

@klihub klihub commented Jan 17, 2022 •
edited by haircommander
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes in some cases incorrectly chosen device node group ID in containers.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Pass host side GID, not UID, as fallback GID to getDeviceUserGroupID().
Update the corresponding unit tests to trigger/catch the original bug.

Does this PR introduce a user-facing change?

None

@klihub
pkg/container: fix container device GID fallback.
25a2eec 
Pass host side GID, not UID, as fallback GID to getDeviceUserGroupID().

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub requested review from mrunalp and runcom as code owners January 17, 2022 22:56
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 17, 2022
@openshift-ci openshift-ci bot requested a review from giuseppe January 17, 2022 22:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

Hi @klihub. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 17, 2022
@klihub
Copy link
Contributor Author

klihub commented Jan 17, 2022

@mythi PTAL

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #5548 (25a2eec) into main (74583d2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5548   +/-   ##
=======================================
  Coverage   43.17%   43.17%           
=======================================
  Files         123      123           
  Lines       12173    12173           
=======================================
  Hits         5256     5256           
  Misses       6414     6414           
  Partials      503      503

mythi
mythi approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klihub thanks a lot! LGTM

giuseppe
giuseppe approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, klihub, mythi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@haircommander
Copy link
Member

haircommander commented Jan 18, 2022

/ok-to-test
/release-note none
/lgtm

thanks @klihub !

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@haircommander haircommander added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 18, 2022
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

@klihub: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 25a2eec link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Jan 18, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 131b3e1 into cri-o:main Jan 18, 2022
@klihub klihub deleted the fixes/device-fallback-gid branch January 18, 2022 16:35
@klihub klihub mentioned this pull request Feb 14, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giuseppe giuseppe giuseppe approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

+1 more reviewer

@mythi mythi mythi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@klihub @haircommander @openshift-bot @giuseppe @mythi @openshift-merge-robot