Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug 1981203] [release-1.23] Fixes Default comments #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wgahnagl wants to merge 2 commits into from
Closed

[Bug 1981203] [release-1.23] Fixes Default comments #5570

wgahnagl wants to merge 2 commits into from

Conversation

@wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Jan 25, 2022

What type of PR is this?

What this PR does / why we need it:

backports defaults comment fix to 1.23

Which issue(s) this PR fixes:

Fixes #1981203

Special notes for your reviewer:

Does this PR introduce a user-facing change?

crio config prints out commented config instead of nothing

Skyler Clark and others added 2 commits January 25, 2022 14:38
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 25, 2022
@openshift-ci openshift-ci bot requested review from giuseppe and sameo January 25, 2022 19:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgahnagl
To complete the pull request process, please assign runcom after the PR has been reviewed.
You can assign the PR to them by writing /assign @runcom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #5570 (1e61582) into release-1.23 (a975152) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.23    #5570   +/-   ##
=============================================
  Coverage         43.22%   43.22%           
=============================================
  Files               123      123           
  Lines             12210    12214    +4     
=============================================
+ Hits               5278     5280    +2     
- Misses             6425     6426    +1     
- Partials            507      508    +1

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022 •
edited
Loading

@wgahnagl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_fedora 1e61582 link true /test integration_fedora
ci/openshift-jenkins/integration_crun_cgroupv2 1e61582 link false /test integration_cgroupv2
ci/openshift-jenkins/integration_crun 1e61582 link true /test integration_crun
ci/openshift-jenkins/integration_rhel 1e61582 link true /test integration_rhel
ci/openshift-jenkins/e2e_crun_cgroupv2 1e61582 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Feb 28, 2022

@wgahnagl can you rebase off of 1.23 to see if it fixes tests?

@saschagrunert
Copy link
Member

saschagrunert commented Jun 28, 2022

A friendly reminder that this PR had no activity for 30 days.

@saschagrunert saschagrunert added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2022
@haircommander
Copy link
Member

haircommander commented Jun 28, 2022

@wgahnagl can you to rebase this?

@sohankunkerkar
Copy link
Member

sohankunkerkar commented Sep 14, 2023

@cri-o/cri-o-maintainers Do we still need this?

@haircommander
Copy link
Member

haircommander commented Sep 14, 2023

I don't think so anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe

@sameo sameo Awaiting requested review from sameo

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wgahnagl @haircommander @saschagrunert @sohankunkerkar