Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bumps containers/storage to 1.38.2 #5585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wgahnagl wants to merge 1 commit into from
Closed

bumps containers/storage to 1.38.2 #5585

wgahnagl wants to merge 1 commit into from

Conversation

@wgahnagl
Copy link
Contributor

@wgahnagl wgahnagl commented Jan 31, 2022

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

updates containers/storage to 1.38.2, fixes NewManager change in internal/config/cgmgr/cgroupfs.go

Which issue(s) this PR fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=1977660
merges bugfix in containers to crio

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fixes garbled symlink error

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 31, 2022
@wgahnagl wgahnagl force-pushed the bump_containers_storage_1.38.2 branch from 5265216 to 907f175 Compare January 31, 2022 20:00
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jan 31, 2022
haircommander
haircommander approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@haircommander haircommander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, wgahnagl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2022
@openshift-bot
Copy link

openshift-bot commented Jan 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member

haircommander commented Jan 31, 2022

actually

/lgtm cancel

let's get #5577 in first

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 31, 2022
@wgahnagl wgahnagl force-pushed the bump_containers_storage_1.38.2 branch from 907f175 to aee41ab Compare February 1, 2022 15:53
@wgahnagl wgahnagl force-pushed the bump_containers_storage_1.38.2 branch from aee41ab to 431880b Compare February 2, 2022 19:54
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2022 •
edited
Loading

@wgahnagl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/e2e_features_fedora 431880b link true /test e2e_features_fedora
ci/openshift-jenkins/integration_crun_cgroupv2 431880b link false /test integration_cgroupv2
ci/openshift-jenkins/integration_rhel 431880b link true /test integration_rhel
ci/prow/e2e-gcp 431880b link true /test e2e-gcp
ci/prow/e2e-agnostic 431880b link true /test e2e-agnostic
ci/openshift-jenkins/e2e_crun_cgroupv2 431880b link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2022

@wgahnagl: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2022
@saschagrunert
Copy link
Member

saschagrunert commented Jun 23, 2022

That's already done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haircommander haircommander haircommander approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@giuseppe giuseppe Awaiting requested review from giuseppe

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wgahnagl @openshift-bot @haircommander @saschagrunert