oci: always reap conmon zombies #5500
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Even if we kill the process, we still need to wait for it, or else we'll reap a zombie. Signed-off-by: Peter Hunt <[email protected]>
ad0e846 to
9f81e4a
Compare
Codecov Report
@@ Coverage Diff @@
## main #5500 +/- ##
==========================================
- Coverage 43.27% 43.26% -0.02%
==========================================
Files 120 120
Lines 11995 12001 +6
==========================================
+ Hits 5191 5192 +1
- Misses 6309 6314 +5
Partials 495 495 |
|
/override ci/openshift-jenkins/integration_crun |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_crun DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test integration_fedora |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/cherry-pick release-1.22 |
|
@haircommander: new pull request created: #5503 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In cri-o#5500, defensive code was added to ensure all child processes are cleaned up when conmon early initialization fails. This bats test forces one of the error scenarios (by adding an unparseable workload annotation to a container) and then ensures no zombies leak in this failure scenario. Verified by temporarily reverting cri-o#5500 (test fails with 10 zombies created), then bringing back cri-o#5500 (test passes) Signed-off-by: Jim Ramsay <[email protected]>
In cri-o#5500, defensive code was added to ensure all child processes are cleaned up when conmon early initialization fails. This bats test forces one of the error scenarios (by adding an unparseable workload annotation to a container) and then ensures no zombies leak in this failure scenario. Verified by temporarily reverting cri-o#5500 (test fails with 10 zombies created), then bringing back cri-o#5500 (test passes) Signed-off-by: Jim Ramsay <[email protected]>
In cri-o#5500, defensive code was added to ensure all child processes are cleaned up when conmon early initialization fails. This bats test forces one of the error scenarios (by adding an unparseable workload annotation to a container) and then ensures no zombies leak in this failure scenario. Verified by temporarily reverting cri-o#5500 (test fails with 10 zombies created), then bringing back cri-o#5500 (test passes) Signed-off-by: Jim Ramsay <[email protected]>
Even if we kill the process, we still need to wait for it, or else we'll reap a zombie.
Signed-off-by: Peter Hunt [email protected]
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?