Thanks to visit codestin.com
Credit goes to github.com

Skip to content

server: don't set memory swap when it's not enabled #5539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 9, 2022
Merged

server: don't set memory swap when it's not enabled #5539

openshift-merge-robot merged 1 commit into from
Feb 9, 2022

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Jan 11, 2022

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix a bug where memory swap values were specified even if the memory swap cgroup is not enabled

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 11, 2022
@openshift-ci openshift-ci bot requested a review from rhatdan January 11, 2022 19:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@haircommander
Copy link
Member Author

haircommander commented Jan 11, 2022

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 11, 2022
@haircommander haircommander mentioned this pull request Jan 11, 2022
Closed
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #5539 (ff2a04e) into main (6df2e9d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #5539      +/-   ##
==========================================
- Coverage   43.12%   43.11%   -0.02%     
==========================================
  Files         121      121              
  Lines       12145    12146       +1     
==========================================
- Hits         5238     5237       -1     
- Misses       6404     6406       +2     
  Partials      503      503

giuseppe
giuseppe approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022 •
edited
Loading

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 ff2a04e link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 ff2a04e link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kashifest added a commit to Nordix/metal3-dev-tools that referenced this pull request Jan 26, 2022
@kashifest
Downgrade crictl to 1.22.0
3c29852 
cri-o 1.23.0 suffering from a bug cri-o/cri-o#5539
@kashifest kashifest mentioned this pull request Jan 26, 2022
Merged
kashifest added a commit to Nordix/metal3-dev-tools that referenced this pull request Jan 26, 2022
@kashifest
Downgrade crictl to 1.22.0
13fd23f 
cri-o 1.23.0 suffering from a bug cri-o/cri-o#5539
@haircommander
Copy link
Member Author

haircommander commented Feb 8, 2022

@cri-o/cri-o-maintainers PTAL

@haircommander
Copy link
Member Author

haircommander commented Feb 8, 2022

/cherry-pick release-1.23

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 8, 2022

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.23 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saschagrunert
saschagrunert approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@saschagrunert
Copy link
Member

saschagrunert commented Feb 9, 2022

/retest-required

@fgiudici
Copy link
Contributor

fgiudici commented Feb 9, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgiudici, giuseppe, haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented Feb 9, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9c1d08e into cri-o:main Feb 9, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 9, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 9, 2022

@haircommander: new pull request created: #5614

Details

In response to this:

/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fgiudici fgiudici mentioned this pull request Feb 15, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giuseppe giuseppe giuseppe approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@rhatdan rhatdan Awaiting requested review from rhatdan

+1 more reviewer

@fgiudici fgiudici fgiudici approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

@fgiudici fgiudici

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@haircommander @openshift-cherrypick-robot @saschagrunert @fgiudici @openshift-bot @giuseppe @openshift-merge-robot