test/cgroups.bats: fix incorrect setup order. #5684
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't dereference $TESTDATA before the test case is set up. Doing otherwise breaks proper isolation of test cases. This manifests itself in many ways, since concurrently cgroups BATS tests can now interfere with each other when mangling test input data. The most typical symptom is the expected memory limit being incorrect in one of the test cases like this: not ok 14 cgroupv2 unified support # (in test file ./cgroups.bats, line 103) # `[[ "$output" == *"209715200"* ]]' failed Signed-off-by: Krisztian Litkey <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #5684 +/- ##
=======================================
Coverage 43.18% 43.18%
=======================================
Files 123 123
Lines 12267 12267
=======================================
+ Hits 5297 5298 +1
+ Misses 6462 6461 -1
Partials 508 508 |
Contributor
Author
|
/test integration_cgroupv2 |
Contributor
Author
|
/retest-required |
Member
|
/approve breaking them out makes sense to me |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, klihub The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't dereference $TESTDATA before the test case is set up. The incorrect setup order prevents
cgroups.batstests from being properly isolated from each other, causing very often
localintegrationcgroups tests to fail in github workflows or OpenShift CI.What type of PR is this?
/kind ci
What this PR does / why we need it:
Don't dereference $TESTDATA before the test case is set up.
Doing otherwise breaks proper isolation of test cases. This
manifests itself in many ways, since concurrently cgroups
BATS tests can now interfere with each other when mangling
test input data. The most typical symptom is the expected
memory limit being incorrect in one of the test cases like
this:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Like the BATS installation fixing bits, this one was also split out from #5596,
so we can merge it ASAP without the remaining other a bit more problematic
bits there.
Does this PR introduce a user-facing change?