Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: update kubernetes build #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
haircommander wants to merge 5 commits into from
Closed

ci: update kubernetes build #5612

haircommander wants to merge 5 commits into from

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Feb 8, 2022

What type of PR is this?

/kind ci

What this PR does / why we need it:

we should use the main branch, as well as set CRI stats in a less hacky way

Which issue(s) this PR fixes:

Special notes for your reviewer:

more details in commits

Does this PR introduce a user-facing change?

none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI labels Feb 8, 2022
@openshift-ci openshift-ci bot requested a review from kolyshkin February 8, 2022 20:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022 •
edited
Loading

Codecov Report

Merging #5612 (4399b5c) into main (9c1d08e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5612   +/-   ##
=======================================
  Coverage   43.23%   43.23%           
=======================================
  Files         123      123           
  Lines       12223    12223           
=======================================
  Hits         5285     5285           
  Misses       6430     6430           
  Partials      508      508

saschagrunert
saschagrunert approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@openshift-bot
Copy link

openshift-bot commented Feb 9, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Feb 9, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Feb 9, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Feb 9, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Feb 9, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Feb 9, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

New changes are detected. LGTM label has been removed.

@haircommander
Copy link
Member Author

haircommander commented Feb 9, 2022

/retest

@haircommander
Copy link
Member Author

haircommander commented Feb 9, 2022

@cri-o/cri-o-maintainers PTAL and return me the tag

@haircommander
Copy link
Member Author

haircommander commented Feb 9, 2022 •
edited
Loading

holy cow e2e_crun_cgroupv2 passed for the first time in months

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022 •
edited
Loading

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 4399b5c link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

TomSweeneyRedHat
TomSweeneyRedHat reviewed Feb 9, 2022
View reviewed changes
contrib/test/integration/main.yml
include: "build/kubernetes.yml"
vars:
k8s_git_version: "release-1.21"
k8s_git_version: "master"
Copy link
Contributor

@TomSweeneyRedHat TomSweeneyRedHat Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they really still using "master" and not "main"? Sigh.

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Feb 9, 2022

One sigh, otherwise LGTM

@haircommander
Copy link
Member Author

haircommander commented Feb 10, 2022

@cri-o/cri-o-maintainers PTAL

fgiudici
fgiudici approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgiudici, haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fgiudici fgiudici mentioned this pull request Feb 15, 2022
Closed
4 tasks
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2022

@haircommander: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

+2 more reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@fgiudici fgiudici fgiudici approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci Categorizes issue or PR as related to CI needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haircommander @openshift-bot @TomSweeneyRedHat @saschagrunert @fgiudici