Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.19] various deadlock fixes #5617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haircommander merged 4 commits into from
Feb 14, 2022
Merged

[1.19] various deadlock fixes #5617

haircommander merged 4 commits into from
Feb 14, 2022
+6 −6

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Feb 9, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

#5535 #5475

Which issue(s) this PR fixes:

cherry-pick of relevant commits of #5475

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Feb 9, 2022
@openshift-ci openshift-ci bot requested review from nalind and umohnani8 February 9, 2022 21:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022 •
edited
Loading

Codecov Report

Merging #5617 (89bbf14) into release-1.19 (5d5a465) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           release-1.19    #5617   +/-   ##
=============================================
  Coverage         43.29%   43.29%           
=============================================
  Files               115      115           
  Lines              9888     9887    -1     
=============================================
  Hits               4281     4281           
+ Misses             5224     5223    -1     
  Partials            383      383

saschagrunert
saschagrunert approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented Feb 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

openshift-bot commented Feb 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Feb 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Feb 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Feb 10, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member Author

haircommander commented Feb 10, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2022
@haircommander
ci/e2e: pin to kubernetes 1.19
d660c50 
Signed-off-by: Peter Hunt <[email protected]>
@haircommander
ci/e2e: pin kubetest commit
89bbf14 
to a version that better supports 1.19

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2022 •
edited
Loading

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_rhel 89bbf14 link true /test integration_rhel
ci/openshift-jenkins/integration_fedora 89bbf14 link true /test integration_fedora
ci/openshift-jenkins/e2e_features_fedora 89bbf14 link true /test e2e_features_fedora
ci/openshift-jenkins/e2e_crun_cgroupv2 89bbf14 link false /test e2e_cgroupv2
ci/openshift-jenkins/e2e_crun 89bbf14 link true /test e2e_crun

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

haircommander commented Feb 14, 2022

enough tests pass in such an old branch--merging

@haircommander haircommander merged commit 391175b into cri-o:release-1.19 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@nalind nalind Awaiting requested review from nalind

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haircommander @openshift-bot @saschagrunert