contrib/bundle: remove deprecated kubelet option. #5639
Conversation
Don't try using deprecated --non-masquerade-cidr kubelet command line option. It was recently removed and breaks tests in CI. Signed-off-by: Krisztian Litkey <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #5639 +/- ##
==========================================
- Coverage 43.23% 43.03% -0.21%
==========================================
Files 123 123
Lines 12221 12279 +58
==========================================
Hits 5284 5284
- Misses 6429 6487 +58
Partials 508 508 |
|
/retest |
|
/approve thanks @klihub ! @cri-o/cri-o-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, klihub The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM, thanks @klihub! A nit (which I do not think is worth re-spinning the PR because of that), would be nice to have a reference for the deprecation, even if as a comment in this PR. |
|
/lgtm |
Kubernetes PR kubernetes/kubernetes#107096, commit kubernetes/kubernetes@2180904 |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@klihub: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Don't pass the deprecated
--non-masquerade-cidrcommand line option tokubelet. It was recently removed altogether and now breaks tests in CI.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?