Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.20] server: filter sysctls passed through CRI if host namespace #5702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 4, 2022
Merged

[release-1.20] server: filter sysctls passed through CRI if host namespace #5702

openshift-merge-robot merged 2 commits into from
Mar 4, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 4, 2022

This is an automated cherry-pick of #5686

/assign haircommander

Fix a bug where a pod given a host IPC or network namespace could configure sysctls on the host

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2022
Merged
@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 4, 2022
@openshift-ci openshift-ci bot requested review from kolyshkin and vrothberg March 4, 2022 17:44
@haircommander haircommander changed the title [release-1.20] [1.21] server: filter sysctls passed through CRI if host namespace [release-1.20] server: filter sysctls passed through CRI if host namespace Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022 •
edited
Loading

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 83cfdfe link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

haircommander commented Mar 4, 2022

/lgtm
/approve
/override ci/openshift-jenkins/integration_fedora

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/openshift-jenkins/integration_fedora

Details

In response to this:

/lgtm
/approve
/override ci/openshift-jenkins/integration_fedora

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 33afe03 into cri-o:release-1.20 Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@kolyshkin kolyshkin Awaiting requested review from kolyshkin

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@openshift-cherrypick-robot @haircommander @openshift-merge-robot