Thanks to visit codestin.com
Credit goes to github.com

Skip to content

crio:fix a bug about log container #5843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 6, 2022
Merged

crio:fix a bug about log container #5843

openshift-merge-robot merged 1 commit into from
May 6, 2022

Conversation

@jwcesign
Copy link
Contributor

@jwcesign jwcesign commented May 4, 2022 •
edited
Loading

crio:fix a bug about log container

Signed-off-by: jiang wei [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

When container is in unknown state, will have this error when log it(using critl and kubectl).
image

fix bug to log container, in upper layer interface, we need status.CreatedAt

Which issue(s) this PR fixes:

none

none

@jwcesign jwcesign requested review from mrunalp and runcom as code owners May 4, 2022 14:25
@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels May 4, 2022
@openshift-ci openshift-ci bot requested review from klihub and wgahnagl May 4, 2022 14:25
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

Hi @jwcesign. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jwcesign
Copy link
Contributor Author

jwcesign commented May 4, 2022 •
edited
Loading

/assign @haircommander

@haircommander
Copy link
Member

haircommander commented May 4, 2022

yeah this makes sense

/ok-to-test
/approve

thanks @jwcesign

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, jwcesign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@haircommander haircommander added this to the 1.24 milestone May 4, 2022
@jwcesign
Copy link
Contributor Author

jwcesign commented May 5, 2022 •
edited
Loading

I check the integration test case, the looks like unpause container work not on time sometimes, it cause failed case when finish.
So I plan to change the logic to delete container when it's in paused state with unpause it first.
what u think? @haircommander

@jwcesign
Copy link
Contributor Author

jwcesign commented May 5, 2022

/retest

@haircommander
Copy link
Member

haircommander commented May 6, 2022

yeah that make sense to me! we're going to cut 1.24.0 today, so it'll have to be backported

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2022
@openshift-bot
Copy link

openshift-bot commented May 6, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jwcesign
Copy link
Contributor Author

jwcesign commented May 6, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit 231af70 into cri-o:main May 6, 2022
@jwcesign jwcesign mentioned this pull request May 15, 2022
Merged
laxmanvallandas pushed a commit to laxmanvallandas/cri-o that referenced this pull request Nov 30, 2022
@openshift-merge-robot
Merge pull request cri-o#5843 from jwcesign/main
6930988 
crio:fix a bug about log container
@laxmanvallandas laxmanvallandas mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@klihub klihub Awaiting requested review from klihub

@wgahnagl wgahnagl Awaiting requested review from wgahnagl

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

1.24

Development

Successfully merging this pull request may close these issues.

4 participants

@jwcesign @haircommander @openshift-bot @openshift-merge-robot