Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump golang dependencies #5917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 8, 2022
Merged

Bump golang dependencies #5917

openshift-merge-robot merged 1 commit into from
Jun 8, 2022

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 31, 2022

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

Update some non-breaking golang dependencies to their latest versions.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Updated golang dependencies

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/dependency-change Categorizes issue or PR as related to changing dependencies dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 31, 2022
@openshift-ci openshift-ci bot requested review from QiWang19 and klihub May 31, 2022 11:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@saschagrunert saschagrunert force-pushed the deps branch 5 times, most recently from feb6ce5 to 04eaec4 Compare May 31, 2022 11:21
@saschagrunert saschagrunert changed the title WIP: Bump golang dependencies Bump golang dependencies May 31, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2022
@saschagrunert
Copy link
Member Author

saschagrunert commented May 31, 2022

/test kata-containers

@saschagrunert
Copy link
Member Author

saschagrunert commented May 31, 2022

@haircommander PTAL

@saschagrunert
Copy link
Member Author

saschagrunert commented May 31, 2022

/test kata-containers

@saschagrunert
Copy link
Member Author

saschagrunert commented May 31, 2022

/retest

@haircommander
Copy link
Member

haircommander commented May 31, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 1, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

openshift-bot commented Jun 1, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 1, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2022
@kolyshkin kolyshkin mentioned this pull request Jun 2, 2022
Merged
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 7, 2022

/unhold

This required a rebase. PTAL @haircommander

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 7, 2022

/retest

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 7, 2022

/test kata-containers

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 7, 2022

/retest

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 7, 2022

@fidencio do you mind giving the kata logs another pair of eyes? I think we break up something by just bumping some golang dependencies 🤔

@saschagrunert saschagrunert force-pushed the deps branch 3 times, most recently from c30a1ef to 846397e Compare June 8, 2022 09:56
@saschagrunert
Bump golang dependencies
24d4019 
Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 8, 2022

/test e2e_features_fedora

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 8, 2022

/retest-required

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 8, 2022

@haircommander another try, we're deferring the containerd bump because it breaks kata for without further code changes. PTAL

@haircommander
Copy link
Member

haircommander commented Jun 8, 2022

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@haircommander: Overrode contexts on behalf of haircommander: ci/prow/e2e-agnostic, ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

saschagrunert commented Jun 8, 2022

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-agnostic, ci/prow/e2e-gcp

Details

In response to this:

/override ci/prow/e2e-agnostic
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8430e11 into cri-o:main Jun 8, 2022
@saschagrunert saschagrunert deleted the deps branch June 8, 2022 16:24
@kolyshkin kolyshkin mentioned this pull request Jun 8, 2022
Closed
@littlejawa littlejawa mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fidencio fidencio Awaiting requested review from fidencio

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@haircommander haircommander

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saschagrunert @haircommander @openshift-bot @openshift-merge-robot